Move from unittest-cpp to catch for unit testing. #533
Conversation
This PR replaces UnitTest-cpp with Catch. Catch is downloaded using cmake's ExternalProject_Add and installed into the include directory as it's a header only library. Signed-off-by: Rian Quinn <“[email protected]”>
|
Awesome. Once this is merged I will start work on getting the clang-format stuff integrated into Travis CI as we discussed. |
|
oh, and will also up-rev the version of catch to include the NO_SELFTEST work that we got upstreamed which should speed up Travis. |
|
Actually...you can't just up-rev the version of catch at will I'm afraid. Each time we change the version that we snap to, I need to update legal documentation to keep everyone happy. Are there likely to be other upgrades/changes to Catch worth waiting on so we can batch up that effort? |
|
I'm not sure, but we are in no hurry either. As far as I know, the answer is no as we are not really using that much of Catch.hpp. Most of the cygwin issues that I know of have been fixed in the version you have, and it works fine with VS, GCC and Clang. |
|
Great. So this seems like the right version to start from. Let's sit with it for a little while (a month or so) and if nothing else worth waiting for appears to be on the horizon, we can bump the version. |
|
sounds great |
Many thanks to @rianquinn. This should fix microsoft#495, microsoft#494 and microsoft#529.
Many thanks to @rianquinn. This should fix #495, #494 and #529.