Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(markdown-magic): Extract transformations into their own modules #21773

Merged

Conversation

Josmithr
Copy link
Contributor

@Josmithr Josmithr commented Jul 3, 2024

Also...

  • simplifies pattern used for template-based transforms.
  • adds missing README documentation for the new import instructions transform

@Josmithr Josmithr requested review from tylerbutler, alexvy86 and a team July 3, 2024 22:38
@github-actions github-actions bot added area: build Build related issues base: main PRs targeted against main branch labels Jul 3, 2024
@Josmithr
Copy link
Contributor Author

Josmithr commented Jul 3, 2024

No test changes, and no changes when running npm run build:readme from the root. No functional regressions: validated 😎

@tylerbutler
Copy link
Member

This should have triggered a client CI build, but didn't. #21775 should fix that. If you manually validated that should be enough for this PR.

@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 455.4 KB 455.44 KB +35 Bytes
azureClient.js 553.01 KB 553.06 KB +49 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 256.72 KB 256.73 KB +14 Bytes
fluidFramework.js 385.28 KB 385.29 KB +14 Bytes
loader.js 134.01 KB 134.03 KB +14 Bytes
map.js 42.17 KB 42.17 KB +7 Bytes
matrix.js 145.43 KB 145.44 KB +7 Bytes
odspClient.js 520.81 KB 520.85 KB +49 Bytes
odspDriver.js 96.94 KB 96.96 KB +21 Bytes
odspPrefetchSnapshot.js 42.23 KB 42.24 KB +14 Bytes
sharedString.js 162.51 KB 162.52 KB +7 Bytes
sharedTree.js 375.74 KB 375.75 KB +7 Bytes
Total Size 3.24 MB 3.25 MB +245 Bytes

Baseline commit: 05193dc

Generated by 🚫 dangerJS against eee0b27

@Josmithr Josmithr merged commit 6b2ffb3 into microsoft:main Jul 8, 2024
36 checks passed
@Josmithr Josmithr deleted the markdown-magic/header-and-footer-templates branch July 8, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: build Build related issues base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants