Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win32 Keyboard: Simplify right-hand CTRL/SHIFT/ALT detection #316

Merged
merged 1 commit into from
May 6, 2022

Conversation

DJm00n
Copy link
Contributor

@DJm00n DJm00n commented Apr 13, 2022

No description provided.

@walbourn
Copy link
Member

This seems to add more computation to all the keys when only SHIFT, CTRL, and ALT need anything to be done.

What's the motivation for this chagne?

@DJm00n
Copy link
Contributor Author

DJm00n commented Apr 16, 2022

@walbourn You're right. I have updated the code. I hope now its clearer.

@walbourn walbourn self-assigned this May 2, 2022
@walbourn walbourn added maintainence input Related to GamePad, Keyboard, and Mouse labels May 2, 2022
@walbourn walbourn self-requested a review May 6, 2022 02:06
@walbourn walbourn merged commit 3be590b into microsoft:main May 6, 2022
@DJm00n DJm00n deleted the wm-keydown-flags branch May 6, 2022 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
input Related to GamePad, Keyboard, and Mouse maintainence
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants