Use git rev-parse to get last commit sha #6366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use `git describe`, it is using tags which might be out of date and unrelated to the current build and version.
You can test this locally with the following command:darker --check --diff -r 5a3178590581b4a7deea17dd45b6c4f1b51edb53..314e5b9c344ce2f04478c808e98f4f2fef5cb158 utils/version/gen_version.pyView the diff from darker here.--- gen_version.py 2024-02-29 18:43:01.000000 +0000
+++ gen_version.py 2024-02-29 18:44:03.894382 +0000
@@ -36,10 +36,11 @@
return output.decode('ASCII').strip()
def is_dirty():
diff = get_output_of(["git", "diff", "HEAD", "--shortstat"])
return len(diff.strip()) != 0
+
def get_last_commit_sha():
try:
sha = get_output_of(["git", "rev-parse", "--short", "HEAD"])
if is_dirty():
|
tex3d
reviewed
Feb 28, 2024
tex3d
approved these changes
Feb 29, 2024
bob80905
approved these changes
Feb 29, 2024
hekota
added a commit
to hekota/DirectXShaderCompiler
that referenced
this pull request
Feb 29, 2024
Do not use `git describe`, it is using tags which might be out of date and unrelated to the current build and version. (cherry picked from commit aaab2a7)
hekota
added a commit
that referenced
this pull request
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use
git describe, it is using tags which might be out of date and unrelated to the current build and version.