Skip to content

Commit

Permalink
Fix Pool and Image name declarations (#603)
Browse files Browse the repository at this point in the history
* Fix Pool and Image name declarations

* Update Changelog.md

* Fix image name

* Update README.md

* Dependencies
  • Loading branch information
gfs authored Feb 7, 2024
1 parent bd77ec3 commit d08607c
Show file tree
Hide file tree
Showing 11 changed files with 28 additions and 24 deletions.
4 changes: 4 additions & 0 deletions Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.0.30] - 2024-1-31
### Pipeline
Additional pipeline fixes

## [1.0.29] - 2024-1-17
### Pipeline
Fix GitHub binary release process
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
<ItemGroup>
<PackageReference Include="CommandLineParser" Version="2.9.1" />
<PackageReference Include="LibGit2Sharp" Version="0.29.0" />
<PackageReference Include="Microsoft.CST.ApplicationInspector.Logging" Version="1.9.17" />
<PackageReference Include="Microsoft.CST.ApplicationInspector.Logging" Version="1.9.18" />
<PackageReference Include="Microsoft.Extensions.CommandLineUtils" Version="1.1.1" />
<PackageReference Include="Sarif.Sdk" Version="4.4.0" />
</ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
<PackageReference Include="MSTest.TestAdapter" Version="3.1.1" />
<PackageReference Include="MSTest.TestFramework" Version="3.1.1" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
<PackageReference Include="MSTest.TestAdapter" Version="3.2.0" />
<PackageReference Include="MSTest.TestFramework" Version="3.2.0" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion DevSkim-DotNet/Microsoft.DevSkim/Microsoft.DevSkim.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.CST.ApplicationInspector.RulesEngine" Version="1.9.17" />
<PackageReference Include="Microsoft.CST.ApplicationInspector.RulesEngine" Version="1.9.18" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
</ItemGroup>

Expand Down
4 changes: 2 additions & 2 deletions Pipelines/cli/devskim-cli-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ resources:
- repository: templates
type: git
name: SecurityEngineering/OSS-Tools-Pipeline-Templates
ref: refs/tags/v1.1.0
ref: refs/tags/v1.1.1

variables:
BuildConfiguration: 'Release'
Expand All @@ -26,7 +26,7 @@ stages:
parameters:
jobName: 'dotnet_test_windows'
dotnetVersions: ['6.0.x','7.0.x','8.0.x']
vmImage: 'oss-tools-win2022_1es-managed'
vmImage: 'win2022-image-base'
projectPath: 'DevSkim-DotNet/Microsoft.DevSkim.Tests/Microsoft.DevSkim.Tests.csproj'
- template: dotnet-test-job.yml@templates
parameters:
Expand Down
8 changes: 4 additions & 4 deletions Pipelines/cli/devskim-cli-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ resources:
- repository: templates
type: git
name: SecurityEngineering/OSS-Tools-Pipeline-Templates
ref: refs/tags/v1.1.0
ref: refs/tags/v1.1.1

variables:
BuildConfiguration: 'Release'
Expand All @@ -31,7 +31,7 @@ stages:
parameters:
jobName: 'dotnet_test_windows'
dotnetVersions: ['6.0.x','7.0.x','8.0.x']
vmImage: 'oss-tools-win2022_1es-managed'
vmImage: 'win2022-image-base'
projectPath: 'DevSkim-DotNet/Microsoft.DevSkim.Tests/Microsoft.DevSkim.Tests.csproj'
- template: dotnet-test-job.yml@templates
parameters:
Expand Down Expand Up @@ -96,8 +96,8 @@ stages:
- job: sign_hash_release
displayName: Code Sign, Generate Hashes, Publish Public Releases
pool:
name: 'OSS-Tools-1ESPool'
vmImage: 'oss-tools-win2022_1es-managed'
name: 'CSPA'
vmImage: 'win2022-image-base'
steps:
- task: UseDotNet@2
inputs:
Expand Down
2 changes: 1 addition & 1 deletion Pipelines/vs/devskim-visualstudio-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ resources:
- repository: templates
type: git
name: SecurityEngineering/OSS-Tools-Pipeline-Templates
ref: refs/tags/v1.1.0
ref: refs/tags/v1.1.1

stages:
- stage: SDL
Expand Down
6 changes: 3 additions & 3 deletions Pipelines/vs/devskim-visualstudio-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ resources:
- repository: templates
type: git
name: SecurityEngineering/OSS-Tools-Pipeline-Templates
ref: refs/tags/v1.1.0
ref: refs/tags/v1.1.1

stages:
- stage: SDL
Expand Down Expand Up @@ -76,8 +76,8 @@ stages:
- job: sign_hash_release
displayName: Code Sign, Generate Hashes, Publish Public Release
pool:
name: 'OSS-Tools-1ESPool'
vmImage: 'windows-latest'
name: 'CSPA'
vmImage: 'win2022-image-base'
steps:
- template: nbgv-set-version-steps.yml@templates
- task: DownloadBuildArtifacts@0
Expand Down
6 changes: 3 additions & 3 deletions Pipelines/vscode/devskim-vscode-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ resources:
- repository: templates
type: git
name: SecurityEngineering/OSS-Tools-Pipeline-Templates
ref: refs/tags/v1.1.0
ref: refs/tags/v1.1.1

stages:
- stage: SDL
Expand All @@ -28,8 +28,8 @@ stages:
- job: build_vscode_plugin
displayName: Build VS Code Plugin
pool:
name: 'OSS-Tools-1ESPool'
vmImage: 'oss-tools-win2022_1es-managed'
name: 'CSPA'
vmImage: 'win2022-image-base'
steps:
- task: UseDotNet@2
displayName: Install Dotnet SDK
Expand Down
10 changes: 5 additions & 5 deletions Pipelines/vscode/devskim-vscode-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ resources:
- repository: templates
type: git
name: SecurityEngineering/OSS-Tools-Pipeline-Templates
ref: refs/tags/v1.1.0
ref: refs/tags/v1.1.1

stages:
- stage: SDL
Expand All @@ -33,8 +33,8 @@ stages:
- job: build_vscode_plugin
displayName: Build VS Code Plugin
pool:
name: 'OSS-Tools-1ESPool'
vmImage: 'oss-tools-win2022_1es-managed'
name: 'CSPA'
vmImage: 'win2022-image-base'
steps:
- task: UseDotNet@2
displayName: Install Dotnet SDK
Expand Down Expand Up @@ -133,8 +133,8 @@ stages:
- job: sign_hash_release
displayName: Code Sign, Generate Hashes, Publish Public Release
pool:
name: 'OSS-Tools-1ESPool'
vmImage: 'oss-tools-win2022_1es-managed'
name: 'CSPA'
vmImage: 'win2022-image-base'
steps:
- template: nbgv-set-version-steps.yml@templates
- task: DownloadBuildArtifacts@0
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ Once the DevSkim plugin is installed and enabled, simply write some code, and fe
## Writing Rules

Please see [Writing Rules](https://github.com/Microsoft/DevSkim/wiki/Writing-Rules) for
instructions on how to author new rules.
instructions on how to author rules.

## Contributing

Expand Down

0 comments on commit d08607c

Please sign in to comment.