Skip to content

Commit

Permalink
Add Job Id to the Signed_Binaries pipeline artifact name (#609)
Browse files Browse the repository at this point in the history
* Append Job Id and Attempt to Pipeline Signed Artifacts

If the pipeline fails during deployment the failed job cannot be rerun because this task will fail because the signed_binaries artifact already exists. However, the entire task also can't be re-run because the extensions have already been published by the time it hits this point. This PR adds a unique value so the failed job can be rerun in the case of temporary failures like API key rotations.

* Update Changelog.md

* Add IDs to the extension runs as well.
  • Loading branch information
gfs authored Mar 5, 2024
1 parent b08bf6e commit 97454b3
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 4 deletions.
6 changes: 5 additions & 1 deletion Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.0.31] - 2024-1-28
## [1.0.32] - 2024-3-04
### Pipeline
Improvement to pipeline to allow rerunning failed deploy jobs.

## [1.0.31] - 2024-2-28
### Sarif Format
Populate additional fields for GitHub Code scanning

Expand Down
2 changes: 1 addition & 1 deletion Pipelines/cli/devskim-cli-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,7 @@ stages:
displayName: Publish Signed Artifacts to Pipeline
inputs:
targetPath: '$(Build.StagingDirectory)'
artifact: 'Signed_Binaries'
artifact: 'Signed_Binaries_$(System.JobId)_$(System.JobAttempt)'
- task: NuGetCommand@2
displayName: Publish NuGet Packages
inputs:
Expand Down
2 changes: 1 addition & 1 deletion Pipelines/vs/devskim-visualstudio-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ stages:
displayName: Publish Signed Artifact to Pipeline
inputs:
targetPath: '$(Build.StagingDirectory)'
artifact: 'Signed_Extension'
artifact: 'Signed_Extension_$(System.JobId)_$(System.JobAttempt)'
- task: PowerShell@2
displayName: Move VS Marketplace Manifest
inputs:
Expand Down
2 changes: 1 addition & 1 deletion Pipelines/vscode/devskim-vscode-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ stages:
displayName: Publish Signed Artifact to Pipeline
inputs:
targetPath: '$(Build.StagingDirectory)'
artifact: 'Signed_Plugin'
artifact: 'Signed_Plugin_$(System.JobId)_$(System.JobAttempt)'
- task: Npm@1
displayName: Install vsce
inputs:
Expand Down

0 comments on commit 97454b3

Please sign in to comment.