Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent conflict with MINGW32 defines #173

Merged
merged 1 commit into from
Feb 24, 2021
Merged

Prevent conflict with MINGW32 defines #173

merged 1 commit into from
Feb 24, 2021

Conversation

ReneNyffenegger
Copy link
Contributor

@ReneNyffenegger ReneNyffenegger commented Feb 16, 2021 •
edited by ghost
Loading

mingw defines (typedefs?) ULONG_PTR and LONG_PTR, but not _MSC_VER. So the typedef LONG LONG_PTR in detours.h gives an error when compiling with mingw.

Microsoft Reviewers: Open in CodeFlow

@bgianfo bgianfo merged commit 7f33ae3 into microsoft:master Feb 24, 2021
@bgianfo
Copy link
Contributor

bgianfo commented Feb 24, 2021

Thanks!

@bgianfo bgianfo added the enhancement This adds new functionallity to the product label Feb 24, 2021
number201724 pushed a commit to number201724/Detours that referenced this pull request Mar 5, 2021
@ReneNyffenegger @number201724
Prevent conflict with MINGW32 defines (microsoft#173)
3f005fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement This adds new functionallity to the product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ReneNyffenegger @bgianfo