Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tensorboard logging: avoid item() outside gas to improve performance #5135

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

nelyahu
Copy link
Contributor

@nelyahu nelyahu commented Feb 15, 2024

item() causes device/host synchronization

@tjruwase tjruwase added this pull request to the merge queue Feb 15, 2024
Merged via the queue into microsoft:master with commit fac1df9 Feb 15, 2024
12 checks passed
mauryaavinash95 pushed a commit to mauryaavinash95/DeepSpeed that referenced this pull request Feb 17, 2024
…icrosoft#5135)

item() causes device/host synchronization

Co-authored-by: Olatunji Ruwase <[email protected]>
rraminen pushed a commit to ROCm/DeepSpeed that referenced this pull request May 9, 2024
…icrosoft#5135)

item() causes device/host synchronization

Co-authored-by: Olatunji Ruwase <[email protected]>
@nelyahu nelyahu deleted the fix_tb_loss branch June 9, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants