deepspeed engine: fp16 support validation on init #4843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjruwase
reviewed
Dec 21, 2023
deepspeed/runtime/engine.py
Outdated
| @@ -242,6 +242,9 @@ def __init__( | |||
| assert not self.elasticity_enabled(), ("Elasticity is not currently supported" | |||
| " with model parallelism.") | |||
|
|
|||
| if self.fp16_enabled() and not get_accelerator().is_fp16_supported(): | |||
There was a problem hiding this comment.
Can you please move this into _do_sanity_check()?
2a45ef4
to
dd56d55
Compare
tjruwase
approved these changes
Dec 25, 2023
mauryaavinash95
pushed a commit
to mauryaavinash95/DeepSpeed
that referenced
this pull request
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.