[MII] catch error wrt HF version and Mistral #4634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffra
requested review from
RezaYazdaniAminabadi,
mrwyattii,
awan-10,
cmikeh2 and
arashb
as code owners
cmikeh2
approved these changes
Nov 6, 2023
mrwyattii
approved these changes
Nov 6, 2023
mauryaavinash95
pushed a commit
to mauryaavinash95/DeepSpeed
that referenced
this pull request
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user is trying to use Mistral with MII and running
transformers <= 4.34.0they will get a cryptic KeyError from transformers. This is documented on the Mistral model page https://huggingface.co/mistralai/Mistral-7B-v0.1 but is an easy error to run into for users.This PR adds a version check to error out more gracefully. This should address at least part of the issue this user reported: microsoft/DeepSpeed-MII#258