Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix memory leak with zero-3 #3903

Merged
merged 2 commits into from
Jul 10, 2023
Merged

fix memory leak with zero-3 #3903

merged 2 commits into from
Jul 10, 2023

Conversation

jeffra
Copy link
Contributor

@jeffra jeffra commented Jul 7, 2023

  • Explicitly delete __ipg_bucket_flat_buffer in zero 3 optimizer, this field is not being deleted via garbage collection and was causing memory leaks when creating z3 managed models back to back.

@jeffra jeffra enabled auto-merge July 7, 2023 23:35
@jeffra jeffra disabled auto-merge July 7, 2023 23:42
@jeffra jeffra enabled auto-merge July 7, 2023 23:42
@mrwyattii mrwyattii disabled auto-merge July 7, 2023 23:46
@mrwyattii mrwyattii enabled auto-merge July 7, 2023 23:46
@mrwyattii mrwyattii added this pull request to the merge queue Jul 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 8, 2023
@tjruwase tjruwase added this pull request to the merge queue Jul 10, 2023
@tjruwase tjruwase added the merge-queue PRs ready to merge label Jul 10, 2023
Merged via the queue into master with commit af9a622 Jul 10, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-queue PRs ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants