Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tentative autoCancel fix #4457

Merged
merged 4 commits into from
Nov 3, 2022
Merged

Conversation

@achamayou achamayou requested a review from a team as a code owner November 2, 2022 17:59
Copy link
Member

@MahatiC MahatiC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I guess the only way to check this works is by merging it?

@achamayou
Copy link
Member Author

@MahatiC I'm hoping that it works on the PR and that I can test it by pushing another commit just now :) Let's see!

@achamayou
Copy link
Member Author

It does seem to work. The jobs apparently get canceled with extreme prejudice, but do free up their slot in the pool queue, and that's the main thing we want:

image

@achamayou achamayou enabled auto-merge (squash) November 2, 2022 18:14
@ccf-bot
Copy link
Collaborator

ccf-bot commented Nov 2, 2022

fix_auto_cancel@53123 aka 20221103.4 vs main ewma over 20 builds from 52718 to 53119

Click to see table

main

build_id build_number tpcc_virtual_cft^ ls_virtual_cft^ ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ hist_sgx_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ Commit latency factor
52718 20221101.29 10978.6 40067.5 10392.9 4050.44 3419.23 3337.06 25803.1 5534.62 8.29727e+07 16197.8 1.6126e+07 5473.76 1.53396e+07 2046.41 8.78598e+06 1698.91 8.78598e+06 1637.36 7.99955e+06 841238 1.18106e+06 8.15566e+06 3.12958e+07 nan
52744 20221101.38 11456.4 41041.3 10209.1 4299.1 3489.45 3234.76 21213.2 5502.32 8.32349e+07 16097.8 1.63882e+07 5445.07 1.56017e+07 2031.6 8.78598e+06 1683.42 8.78598e+06 1616.71 8.2617e+06 836979 1.17435e+06 8.15754e+06 3.0842e+07 nan
52774 20221101.47 10552.1 41164.6 10321.5 4279.33 3399.1 3125.67 25082.2 5585.58 8.27106e+07 16217.2 1.63882e+07 5417.87 1.53396e+07 2038.42 8.52384e+06 1691.13 8.52384e+06 1626.78 7.73741e+06 837070 1.18686e+06 8.17147e+06 3.11218e+07 nan
52809 20221101.56 11354.1 40616.9 10066.3 4275.94 3714.35 3269.29 26058.8 5483.38 8.29727e+07 15754.8 1.6126e+07 5392.28 1.53396e+07 2040.53 8.52384e+06 1692.91 8.52384e+06 1637.8 7.99955e+06 835548 1.17751e+06 8.14839e+06 3.08248e+07 nan
52836 20221101.65 12975.4 38685.7 11022.1 3904.35 3125.32 2872.24 22079.4 5666.78 8.3497e+07 15879.2 1.53396e+07 5692.48 1.45532e+07 2058.98 9.04813e+06 1682.43 8.78598e+06 1602.04 7.99955e+06 838363 1.18024e+06 8.13493e+06 3.07111e+07 0.840398
52860 20221101.73 16788.9 45576.9 12595.4 4556.62 3453.83 3222.78 25456.5 6273.01 8.21863e+07 16616.8 1.53396e+07 5956.18 1.50774e+07 2073.62 8.78598e+06 1689.81 8.52384e+06 1625.04 7.73741e+06 829373 1.17726e+06 8.17425e+06 3.14656e+07 0.768566
52889 20221101.81 17527.2 43805.5 12626.2 4401.04 3588.18 3362.47 29637 6306.08 8.29727e+07 16253.5 1.50774e+07 5941.91 1.50774e+07 2069.39 8.52384e+06 1702.49 8.78598e+06 1623.71 7.99955e+06 839729 1.17486e+06 8.15592e+06 3.06959e+07 0.782895
52903 20221101.86 17537.9 43610.3 12588.6 4643.07 3561.49 3229.48 21617.8 5669.25 8.27106e+07 16013.7 1.56017e+07 5655.71 1.48153e+07 2030.98 8.52384e+06 1676.91 8.52384e+06 1579.98 7.99955e+06 832062 1.17538e+06 8.16971e+06 3.08824e+07 0.815599
52919 20221101.90 17265.2 45770.4 12606.2 4582.28 3482.84 3361.88 24079.5 5588.57 8.32349e+07 16023.3 1.58639e+07 5721.75 1.48153e+07 2029.63 8.78598e+06 1684.49 9.04813e+06 1613.61 7.99955e+06 838236 1.1826e+06 8.15374e+06 3.08703e+07 0.826385
52928 20221101.94 17061.2 41901.6 12714.4 4566.57 3623.15 3371.65 24093.5 5580.58 8.27106e+07 16062.6 1.53396e+07 5905.59 1.45532e+07 2035.71 8.78598e+06 1676.17 8.78598e+06 1608.74 7.99955e+06 837289 1.17643e+06 8.17102e+06 3.07364e+07 0.816214
52934 20221101.96 17564.9 43657.7 12483.7 4369.81 3604.1 3374.04 23964.5 6266.01 8.19242e+07 16478.7 1.50774e+07 5868.9 1.45532e+07 2059.88 8.52384e+06 1673.54 8.78598e+06 1635.75 7.73741e+06 839550 1.17918e+06 8.16528e+06 3.11417e+07 0.761476
52941 20221101.98 17782.2 43502.2 12638.7 4433.67 3454.54 3246.07 27599.3 6388.18 8.21863e+07 16628 1.50774e+07 5906.45 1.56017e+07 2099.33 9.31027e+06 1708.45 8.78598e+06 1641.61 7.99955e+06 839624 1.17998e+06 8.15316e+06 3.08941e+07 0.800341
52956 20221102.2 17372.4 41820.9 12622.6 4320.99 3451.7 3372.48 27099.5 6382.1 8.21863e+07 16629.9 1.56017e+07 5919.66 1.50774e+07 2095.36 8.78598e+06 1707.65 8.78598e+06 1642.92 7.99955e+06 834176 1.18165e+06 8.15193e+06 3.15976e+07 0.810117
52978 20221102.10 16900.8 43669.1 12356.4 4263.93 3446.79 3212.91 27567.5 6337.88 8.24484e+07 16612.4 1.50774e+07 5867.78 1.50774e+07 2101.14 8.78598e+06 1713.86 8.52384e+06 1651.38 7.99955e+06 829188 1.18143e+06 8.15231e+06 3.10247e+07 0.741081
52993 20221102.16 17622.5 45461.3 12519.7 4400.03 3485.78 3472.52 27369.4 6358.3 8.19242e+07 16596 1.50774e+07 5857.84 1.48153e+07 2088.69 8.78598e+06 1702.65 8.52384e+06 1636 7.99955e+06 833530 1.17406e+06 8.15348e+06 3.07129e+07 0.752209
53011 20221102.23 17317.4 45538.1 12605.8 4594.7 3401.6 3331.91 21872.5 6397.86 8.21863e+07 16685.7 1.50774e+07 5828.17 1.50774e+07 2096.62 9.31027e+06 1707.86 8.52384e+06 1655.53 7.99955e+06 830855 1.18181e+06 8.17555e+06 3.12105e+07 0.762839
53019 20221102.26 17663.8 43438.3 12652 4406.53 3465.33 3304.89 26785.8 6335.65 8.24484e+07 16470.1 1.50774e+07 6020.97 1.50774e+07 2098.62 9.31027e+06 1709.89 8.52384e+06 1654.03 8.2617e+06 836273 1.17873e+06 8.15579e+06 3.07434e+07 0.798619
53059 20221102.38 16979.9 43589.2 12797.7 4574.2 3600.55 3231.15 25286.8 6308.31 8.19242e+07 16578.5 1.50774e+07 5933.95 1.50774e+07 2081.66 9.04813e+06 1697.66 8.52384e+06 1634.6 7.73741e+06 825102 1.17706e+06 8.15537e+06 3.02985e+07 0.771621
53110 20221102.54 17222.3 43726 12772.7 4570.19 3485.53 3226.55 26905.9 6270.99 8.21863e+07 16538.2 1.50774e+07 5840.48 1.50774e+07 nan nan 1713.44 8.52384e+06 1629.67 7.99955e+06 nan nan nan nan 0.784921
53119 20221103.3 17146.3 43841.2 12575.3 4581.04 3658.62 3255.39 25426.6 6328.1 8.27106e+07 16641.3 1.53396e+07 6081.27 1.50774e+07 2077.81 8.78598e+06 1712.76 8.78598e+06 1653.78 7.99955e+06 830882 1.1846e+06 8.17359e+06 3.102e+07 0.773144

fix_auto_cancel

build_id build_number Commit latency factor tpcc_virtual_cft^ ls_virtual_cft^ ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ hist_sgx_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
53107 20221102.53 0.779641 17677.1 45877 12504.2 4434.98 3433.63 3374.86 21247.8 6303.75 8.24484e+07 16458.6 1.50774e+07 5881.55 1.45532e+07 2069.11 8.78598e+06 1705.46 8.52384e+06 1640.78 7.99955e+06 830173 1.17737e+06 8.0432e+06 3.08095e+07
53123 20221103.4 0.802407 17130.6 43655 12548.9 4624.04 3571.17 3207.25 21965.1 6368.24 8.24484e+07 16693.5 1.50774e+07 5986.64 1.50774e+07 2102.43 9.31027e+06 1709.8 8.52384e+06 1650.58 8.2617e+06 843629 1.17667e+06 8.15342e+06 3.20666e+07

images

@achamayou achamayou merged commit dff1568 into microsoft:main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants