Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Build docs automatically when running release #4018

Merged
merged 7 commits into from
May 21, 2020

Conversation

paulcam206
Copy link
Member

@paulcam206 paulcam206 commented May 15, 2020

Description

Prior to this change, docs would only get generated if you manually ran npm run docs. You can still do manual generation, but I reworked the release script to:

  • Add docs generation
  • Parallelize some of our tasks

The first commit (c9c0f77) has the script changes, and the second (546c360) contains the generated doc changes. Here's a link to just the docs (in readable form).

How Verified

  • local clean build
  • spot check on some of the docs
Microsoft Reviewers: Open in CodeFlow

@paulcam206 paulcam206 added the Platform-JavaScript Bugs or features related to the JavaScript renderer label May 15, 2020
@ghost
Copy link

ghost commented May 15, 2020

Hi @paulcam206. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@shalinijoshi19
Copy link
Member

@paulcam206 what's the story for getting these published to the microsoftdocs repo (and subsequently getting rid of teh version here) ?

@paulcam206
Copy link
Member Author

@paulcam206 what's the story for getting these published to the microsoftdocs repo (and subsequently getting rid of teh version here) ?

We don't currently have a story. We need to figure out a docs versioning story and finish getting our docs fleshed out. Eventually the story will likely involve copying our docs over to the other repo in some subdir. For now I think it's probably sufficient to put links in our existing docs to point to our "in progress" docs.

@paulcam206
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@paulcam206
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@paulcam206
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@paulcam206 paulcam206 merged commit dbf6090 into master May 21, 2020
@paulcam206 paulcam206 deleted the paulcam/automatic-nodejs-docs branch May 21, 2020 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform-JavaScript Bugs or features related to the JavaScript renderer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants