New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix background image repeat behaviours #2957

Merged

almedina-ms merged 1 commit into master from user/almedina-ms/AndroidFixRepeatBackground

May 21, 2019

Contributor

almedina-ms commented May 21, 2019

Fixes #2947

The issue came with the "hackish" trick to avoid containers to grow if a background image was specified even if the background was smaller, there I was adding an empty image of size 1x1 but that overrode the repeat behaviour that was using the actual set background image

Also found out that the incomplete images were not being drawn so I fixed that too

How verified

The mobile app was run and this are the results

AdaptiveCard.BackgroundImage.FillMode.json

AdaptiveCard.BackgroundImage.FillMode.Repeat.json

AdaptiveCard.BackgroundImage.FillMode.RepeatHorizontally.json

AdaptiveCard.BackgroundImage.FillMode.RepeatVertically.json

Column.BackgroundImage.json

Container.BackgroundImage.json


Fix repeat behaviours

2cad65f

almedina-ms requested review from paulcam206, jwoo-msft, RebeccaAnne and shalinijoshi19

May 21, 2019 17:06

paulcam206 approved these changes

View reviewed changes

Member

paulcam206 left a comment

almedina-ms merged commit fa69d5f into master

almedina-ms deleted the user/almedina-ms/AndroidFixRepeatBackground branch

July 31, 2019 20:02

rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request


Fix repeat behaviours (microsoft#2957)

b158559

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment