[UWP] Fix column growing due to background image #2955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almedina-ms
changed the title
paulcam206
reviewed
May 21, 2019
| @@ -114,7 +114,7 @@ | |||
| }, | |||
| { | |||
| "type": "Column", | |||
| "width": "auto", | |||
There was a problem hiding this comment.
th": "auto", [](start = 9, length = 12)
do we have other tests that cover the "width": "auto" case? #ByDesign
There was a problem hiding this comment.
yes but the result looks better with stretch width as auto overflows the card in UWP and WPF
In reply to: 286154178 [](ancestors = 286154178)
There was a problem hiding this comment.
that's fine -- I just wanted to make sure we were getting visual verification for the auto case :)
In reply to: 286155401 [](ancestors = 286155401,286154178)
paulcam206
reviewed
May 21, 2019
| @@ -293,29 +302,47 @@ namespace AdaptiveNamespace | |||
| ComPtr<IUIElement> rectangleAsUIElement; | |||
| THROW_IF_FAILED(rectangleAsShape.As(&rectangleAsUIElement)); | |||
|
|
|||
| double originPositionX = (fillMode == BackgroundImageFillMode::Cover) ? 0.0 : (x * m_imageSize.Width) + offsetHorizontalAlignment; | |||
| double originPositionY = (fillMode == BackgroundImageFillMode::Cover) ? 0.0 : (y * m_imageSize.Height) + offsetVerticalAlignment; | |||
There was a problem hiding this comment.
I think I'd rather see this implemented as an if/else (same below)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2697
The issue was fixed using TileControl to render the cover image and using the ITileBrush interface to position the image where it must be and to stretch it to fill
There may be another issue where the background images make the card grow, this also fixes that
How verified
The test app was run and the results were updated