[.NET] Update nuget packages (builds/tests clean) #2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66a7a08
to
588bec6
Compare
almedina-ms
reviewed
May 10, 2019
| @@ -10,7 +10,7 @@ | |||
| <PackageProjectUrl>https://adaptivecards.io</PackageProjectUrl> | |||
| <PackageIconUrl>https://adaptivecards.io/content/icons_blue/blue-48.png</PackageIconUrl> | |||
| <RepositoryUrl>https://github.com/Microsoft/AdaptiveCards</RepositoryUrl> | |||
| <PackageLicenseUrl>https://raw.githubusercontent.com/Microsoft/AdaptiveCards/master/LICENSE</PackageLicenseUrl> | |||
| <PackageLicenseExpression>MIT</PackageLicenseExpression> | |||
There was a problem hiding this comment.
MIT [](start = 4, length = 56)
why is this set to the MIT value? #ByDesign
There was a problem hiding this comment.
The nuspec goo emitted by PackageLicenseUrl is being deprecated, and tooling was complaining about it. Instead, if you use a canonical well-known license, you use the license type. Otherwise if you have a custom license, you have to embed the license as a file in the project and refer to it directly.
In reply to: 282977498 [](ancestors = 282977498)
almedina-ms
approved these changes
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update .NET project dependencies
Verified by running tests and spot checking a few cards in the visualizer.