[Android] Change null returns for exceptions to avoid ambiguity #2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcam206
approved these changes
Apr 18, 2019
| } | ||
| } | ||
| } | ||
| } | ||
| else if (renderArgs.getAncestorHasFallback()) | ||
| { | ||
| // There's an ancestor with fallback so we throw to test it |
There was a problem hiding this comment.
we throw to trigger it rather than test it, right? #Resolved
…ificationToException
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
…osoft#2715) * Fallback with exceptions v1 * Fix bugs in previous version and add more descriptive details to exception * Update comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds AdaptiveFallbackException to signalize an element couldn't be rendered avoiding the use of null as it may be ambiguous for external developers
How verified
The test cards we have were run and this is the output
Deep fallback
ActionFallback