Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Add classes for validation * Add interfaces for input validation * [UWP] Input Validation Prototype * Second version of validation * Update some stuff * Add minor fixes and ur * Add multitype label support * Fix break * Add support for card elements as labels * Add automation properties * Add fixes for accessibiloty * Add host config support * Fix accessibility for error messages * Add host config options for validation behavior * Modify host config to show enw options * Add files to project * Remove UWP specific code * Remove Android specific code changes * Update test files * [TS] Input validation (#4197) * Work in progress * Code complete * Now actually code complete * Fix not all required inputs gathered from ShowCard * Accessibility support * Add aria-required, hide suffix from accessibility * aria-required for Toggle and ChoiceSet * Add sample Co-authored-by: shalinijoshi19 <[email protected]> Co-authored-by: Paul Campbell <[email protected]> * [Shared model] Update namings in host config (#4213) * Remove validation behaviour from host config * Update namings in hostconfig * Fix build errors * Fix some test json for bugbash * Fix cards with errors * Update long labels to be loooooooooooooooooooooong * [DevSpec] Updates to input validation spec (#4190) * Input Validation Spec Documents * Fix casing on broken image links' * Updates to document based on discussions and feedback * Minor formatting change Updated the "Start the documentation site" heading to be at the same level as the rest of the headings * Removing instructions around explicit hexo install * [Security] Bump handlebars in /source/nodejs/adaptivecards (#3692) * Bump handlebars from 4.1.2 to 4.5.3 in /source/community/reactnative (#3694) * [UWP] Fix null dereference in Media code path (#3669) [UWP] Fix null dereference in Media code path * [UWP] Fix RendererRegistration error handling and fix inheritance issue with WholeItemsPanel (#3710) * updated the doc (#3706) * updated the doc * Updated specs * updated the description * Updated specs * updated the doc to correct wrong info * Updated specs * [Accessibility] Fixing some color contrast issues in the website (#3698) * Updating adaptivecards.io homepage's roadmap links to point to the updated productboard portal * Fixes #3577 ; Fixes #3576: * Fixing outlook.css since that is the style sheet that is being picked up by default when you hit the explorer page * automatic package.json changes * Fixing color syntax * Site readme updates (#3699) 1. Including PreRequisite section around repo bootstrap linking to root readme 2. Cleaning up build commands to use lerna to be consistent with root readme and removing redundant steps * added test to parse and render all sample cards (#3679) Co-authored-by: shalinijoshi19 <[email protected]> * [UWP] Remove image comparison from unit tests (#3724) * [UWP] Remove image comparison from unit tests * Code review feedback * Added MaxActions Limit Check (#3696) * Added MaxActions limit check and replaced multiple of GetActions() call That returns a structure by value * added UnitTesting and Warning * added UnitTesting and Warning fixed comments Co-authored-by: almedina-ms <[email protected]> Co-authored-by: shalinijoshi19 <[email protected]> * Jwoo/ios telephony update (#3680) * updating telephony detection for markdown link * undo uneccesary changes * updated RichTextBlockRenderer to detect Telephony link * updated sample card Co-authored-by: shalinijoshi19 <[email protected]> * [Android] Fix scrolling behaviour in multiline Input.Text (#3714) * Fix scrolling behaviour in multiline text input * Add test files Co-authored-by: shalinijoshi19 <[email protected]> * Fix vertical content alignment for elements in root (#3716) * [SharedModel] Skip date/time tests outside of Pacific TZ (#3611) * [SharedModel] Skip date/time tests outside of Pacific TZ Fixes #3609 * Rename TEST_MODULE_INITIALIZE method * Remove TEST_MODULE_INITIALIZE altogether * Update macro name Co-authored-by: shalinijoshi19 <[email protected]> * Create cortana-beta-light.json (#3729) New HostConfig for Cortana Windows UWP beta, light mode. To be added to the drop down as: Cortana (Beta) - Light * Create cortana-beta-dark.json (#3730) Co-authored-by: Matt Hidinger <[email protected]> * [Android] Fix to have HH:mm in Input.Time elements (#3713) * Fix to have short time format * Change helper function * Add unit tets * Add sample test json * Remove unnecessary test file * Fixed #3741 (#3743) * Updated Cover FillMode Behavior (#3725) * Updated Cover FillMode Behavior * Revew Comments Addresssed * adding testing card * Updated file * Updated Handling of Preprocessed Text (#3727) * Updated preprocessed text handling * updated formatting * Added Accesibility Tags * updated accessibility Co-authored-by: shalinijoshi19 <[email protected]> * updated project file to expose media rendere (#3726) * iOS new layout scheme (#3687) * Updated iOS layout * removed wrapper on TextBlock and RichTextBlock renderers * updated layout views to use intrinsic contentsize * updated property value for layout vies * Added key value observation for hidden property to allow toggle visibility and the new layout change to work together * Updated views with toggle visibility to update its contentsize based on their visibility changes Updated padding priority for bleeding * restores to working project file * updated project file for xcode * updated for CR comments * Fixed for CR comments Co-authored-by: shalinijoshi19 <[email protected]> * updated the gradle property to handle error token (#3742) Co-authored-by: shalinijoshi19 <[email protected]> * More feedback updates * Add backwards compatibility section * Update to labels spec to reflect the latest discussions * Add an update to the label spec to cover the current state of discussions * Update some open discussion and comments * Update link * Flesh out host config options * Fix some comments * Fix more comments * Split original spec into two options * Fix comment from discussion * Get the general spec on track with the other two * Add almost final version * Move costing outside of appendix * Add index to point to topics easier * Add table of contents for validation * Add WCA Guidelines * Add requirements * Update specs * Remove markdown from v1 * Make small updates to input validation spec * Add fixes for comments from last meeting * Update host config structure * Take options out of scope for associated inputs * Add changes from 05/26 meeting * Update requirements * Update last details of spec * [Android] Show all ActionSet's in column (#4181) * Adjust ActionSet container height to fit contents * Add test card * Fix UWP build break after branch change and merge * Revert no longer relevent changes in samples and schema Co-authored-by: Rebecca Muraira <[email protected]> Co-authored-by: shalinijoshi19 <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joseph Woo <[email protected]> Co-authored-by: Paul Campbell <[email protected]> Co-authored-by: jarusse <[email protected]> Co-authored-by: Matt Hidinger <[email protected]> Co-authored-by: Risheek Rajolu <[email protected]> * [UWP] Input Evolution (#4088) * Re add everything related to UWP * Remove validation behaviour from host config * Remove references to validation behaviour * Update input retrieval * Add changes to respect label and error messages on custom inputs * Remove comment and repeated code * Update namings in hostconfig * Update host config and fixes broken error message setting * Fix first batch of comments in PR * Remove render context from input value constructor * Fix more comments from PR * Fix more comments * Fix text wrapping in error message and bug in time input validation * Fix input retrieval bug Co-authored-by: shalinijoshi19 <[email protected]> * [Android] Input labels and errors support (#4039) * First working android version for inputs and errors * Clean up android tests * Fix tests for other input types * Update swig files * Fix build error * Remove validation behaviour from host config * Remove validation behaviour references * Working version n1 for visible views only * Add more changes to respect basic properties as spacing * Add fix to compress casting tasks * Fix some behaviours and check that all inputs work * Update host config * Updsate object model file * Readd legacy card import for testing purposes * Fix android not rendering elements * Fix issues found in bug bash' * Fix test fieks * Fix tests Co-authored-by: shalinijoshi19 <[email protected]> * Fix casting issue * Add missing file from previous commit * [WPF] Input Evolution (#4172) * Add NET shared model support and WPF rendering support for labels and error messages * Fix validation bugs * Fix some acessibility issues Co-authored-by: shalinijoshi19 <[email protected]> * [UWP] Fix inline actions not getting inputs (#4266) * Fix inline actions not validating inputs * Updated specs Co-authored-by: Adaptive Cards Specs CI <[email protected]> * [UWP] Respect host config formatting for labels (#4289) * Fix host config on labels * Fix comments * Fix crashes when no input exist in a card (#4316) * [UWP] Sample custom input (#4282) * Add sample input and changes the use of internal id for string id * Fix commments from PR * [WPF] Rename the input label host config property to match cpp shared model (#4308) * Rename the input label host config properties * Remove build files from git * Remove invalid test cards and add new valid test cards * Remove associated inputs from submit actions * Fix failing tests * Fix test errors * Rename custom input to be the same as other renderers (#4328) * Fix input visibility (#4306) * Fix crash when clicking inline actin (#4290) * Fix samples (#4347) * Remove build files from git * Add properties to hostconfig and fix duplicated id Co-authored-by: shalinijoshi19 <[email protected]> * [TS] Input accessibility + designer open sample dialog fixes (#4239) * [JS] Input accessibility and designer fixes * Fix Input.Number min/max not honored when set to 0 * Update package-lock.json * Further package-lock.json updates Co-authored-by: Paul Campbell (DEP) <[email protected]> Co-authored-by: shalinijoshi19 <[email protected]> * Ts/input label as label (#4354) * [JS] Input label as <label> * Fix typo * Update package-lock.json * Another package-lock update * Small preview mode fix Co-authored-by: Paul Campbell <[email protected]> * [Android] fix focus on elements (#4321) * Add custom input element to verify correct label rendering * Fix Focus Visibility on choiceset elements * Add missing file change * Fix build error Co-authored-by: shalinijoshi19 <[email protected]> * work in progress * completed input view * completed input label & work in progress for inputvalidation * [UWP] Fix crash when invoking show cards (#4370) * Remove control validation (#4379) * [Android] Fix suffix rendering in labels (#4372) * Remove build files from git * Fix label suffix * [Android] Fix visual input cue to clean the state on instantiation (#4373) * Remove build files from git * Fix preloaded visual cue * [Android] Fix empty date input (#4374) * Remove build files from git * Fix date input to allow being empty on start * complted implementing input validation * [JS] Regenerate package-lock files * code complete * Revert "Merge branch 'jwoo/ios-input-evolution' into feature/inputEvolution" This reverts commit dda9109, reversing changes made to 609f25e. * Emit warning for required inputs without label (#4435) * [UWP] Fix Input.Number validation logic to ensure value is a number (#4432) Co-authored-by: shalinijoshi19 <[email protected]> * [WPF] Fix automation properties (#4371) * Remove build files from git * Fix AutomationProperties for Accessibility * Fix comments from pr Co-authored-by: shalinijoshi19 <[email protected]> * Add warnings for empty labels in required inputs (#4409) Co-authored-by: shalinijoshi19 <[email protected]> * Add warning for empty label in required input (#4454) Co-authored-by: shalinijoshi19 <[email protected]> * Add input retrieval to inlinr submit actions (#4453) Co-authored-by: shalinijoshi19 <[email protected]> * [Android] Fix stretch textblock claiming all visible space (#4452) * Fix elements taking the whole space * Add sample files Co-authored-by: shalinijoshi19 <[email protected]> * Sample updates (#4455) Co-authored-by: shalinijoshi19 <[email protected]> * Change choiceset returns from null to empty (#4458) Co-authored-by: shalinijoshi19 <[email protected]> * ios input evolution (#4437) * refactored and fixed bug bash bugs * fixed merge error * added warning messages when there is no error message is present when the input has the validations * refactored code and fixed unit tests * updated failed test card since bad card is fixed Co-authored-by: shalinijoshi19 <[email protected]> * Fix label to make hint always have attention color (#4456) Co-authored-by: shalinijoshi19 <[email protected]> * Fixing .NET CI tests for feature/inputEvolution (#4462) * Ignoring default value for LabelConfig.inputspacing during serialization * Updating API doc * Fixing regression in WPF renderer processing v1.0 inputs * Reverting changes to default launchSettings for the ImageRenderer sample Co-authored-by: Rebecca Muraira <[email protected]> Co-authored-by: shalinijoshi19 <[email protected]> Co-authored-by: Paul Campbell <[email protected]> Co-authored-by: David Claux <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joseph Woo <[email protected]> Co-authored-by: jarusse <[email protected]> Co-authored-by: Matt Hidinger <[email protected]> Co-authored-by: Risheek Rajolu <[email protected]> Co-authored-by: Adaptive Cards Specs CI <[email protected]>
- Loading branch information
12 people
committed
Jul 22, 2020
1 parent
95f9a04
commit c1e9ad0