Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code for Micronaut Framework 5. #2843

Draft
wants to merge 7 commits into
base: 5.0.x
Choose a base branch
from

Conversation

wetted
Copy link
Contributor

@wetted wetted commented Mar 19, 2024

closes #2810

@wetted wetted added the type: breaking Introduces a breaking change label Mar 19, 2024
@wetted wetted self-assigned this Mar 19, 2024
@wetted
Copy link
Contributor Author

wetted commented Mar 19, 2024

ping @dstepanov @sdelamo

I use a little help on this.

  • AbstractDataSourceTransactionManagerCondition doesn't compile if the the deprecated method is removed, but am unsure what all needs to be done here.
  • HibernateQuerySpec and HibernatePostgresQuerySpec tests are now failing. I have not yet investigated why.
  • Still need to add docs for breaking changes. I can work on that in the meantime.

# Conflicts:
#	data-hibernate-jpa/src/test/java/io/micronaut/data/hibernate/BookRepository.java
#	data-model/src/main/java/io/micronaut/data/intercept/annotation/DataMethod.java
#	data-processor/src/main/java/io/micronaut/data/processor/visitors/finders/AbstractPatternMethodMatcher.java
#	gradle.properties
@wetted
Copy link
Contributor Author

wetted commented Apr 2, 2024

@dstepanov TODO:

private Optional<String> transactionManagerProperty(@NonNull ConditionContext context,

@sdelamo sdelamo changed the base branch from 4.7.x to 5.0.x April 9, 2024 04:47
…tions-for-mn5

# Conflicts:
#	data-hibernate-jpa/src/test/java/io/micronaut/data/hibernate/BookRepository.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: breaking Introduces a breaking change
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Del @Deprecated Data
3 participants