Fix lost baggage if more than one #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR and sorry for the delay (I was on PTO) |
marcingrzejszczak
pushed a commit
that referenced
this pull request
Aug 17, 2023
* Modify test to add another baggage in scope and assert presence * Fix such that adding entry respect existing baggage from Context.current()
|
Back-ported to 1.1.x 217284d |
|
Backported to 1.0.x a8f0d06 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding more than one baggage entry, only the last value is kept.
See the modified test which adds KEY_2 and VALUE_2. Only KEY_2 is kept and KEY_1 entry disappears. The original implem always creates a new Baggage with every
createBaggageInScopeThis pull request fixes this problem by having the every baggage entry be added on top of the existing baggage map in
Context.current().