Added Brave, OTel, Zipkin & Wavefront #1

marcingrzejszczak · 2021-11-12T16:50:49Z

No description provided.

sonatype-lift · 2021-11-15T12:29:00Z

...r-tracing-bridge-brave/src/main/java/io/micrometer/tracing/brave/bridge/BraveScopedSpan.java

+ }
+
+ @Override
+ public boolean equals(Object o) {


EqualsGetClass: Overriding Object#equals in a non-final class by using getClass rather than instanceof breaks substitutability of subclasses.
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:01Z

...tracing-bridge-brave/src/main/java/io/micrometer/tracing/brave/bridge/BraveTraceContext.java

+ }
+
+ @Override
+ public boolean equals(Object o) {


EqualsGetClass: Overriding Object#equals in a non-final class by using getClass rather than instanceof breaks substitutability of subclasses.
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:02Z

...-tracing-bridge-otel/src/main/java/io/micrometer/tracing/otel/bridge/OtelBaggageManager.java

+ }
+
+ @Override
+ public boolean equals(Object o) {


EqualsGetClass: Overriding Object#equals in a non-final class by using getClass rather than instanceof breaks substitutability of subclasses.
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:03Z

...er-tracing-bridge-otel/src/main/java/io/micrometer/tracing/otel/bridge/OtelTraceContext.java

+ }
+
+ @Override
+ public boolean equals(Object o) {


EqualsGetClass: Overriding Object#equals in a non-final class by using getClass rather than instanceof breaks substitutability of subclasses.
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:05Z

...tracing-bridge-otel/src/main/java/io/micrometer/tracing/otel/bridge/SpanFromSpanContext.java

+ }
+
+ @Override
+ public boolean equals(Object o) {


EqualsGetClass: Overriding Object#equals in a non-final class by using getClass rather than instanceof breaks substitutability of subclasses.
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:06Z

...n/java/io/micrometer/tracing/reporter/wavefront/WavefrontSpringObservabilitySpanHandler.java

+ new NamedThreadFactory("observability-heart-beater").setDaemon(true));
+
+ // Emit Heartbeats Metrics every 1 min.
+ heartbeatMetricsScheduledExecutorService.scheduleAtFixedRate(() -> {


FutureReturnValueIgnored: Return value of methods returning Future must be checked. Ignoring returned Futures suppresses exceptions thrown from the code that completes the Future.
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:07Z

...ter-tracing-bridge-otel/src/main/java/io/micrometer/tracing/otel/bridge/OtelSpanBuilder.java

+
+ private final io.opentelemetry.api.trace.SpanBuilder delegate;
+
+ private final List<String> annotations = new LinkedList<>();


JdkObsolete: It is very rare for LinkedList to out-perform ArrayList or ArrayDeque. Avoid it unless you're willing to invest a lot of time into benchmarking. Caveat: LinkedList supports null elements, but ArrayDeque does not.
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:08Z

...acing-bridge-brave/src/main/java/io/micrometer/tracing/brave/bridge/BraveBaggageManager.java

+
+ private static final Map<String, BaggageInScope> CACHE = new ConcurrentHashMap<>();
+
+ public Map<String, String> getAllBaggage() {


MissingOverride: getAllBaggage implements method in BaggageManager; expected @OverRide
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:09Z

micrometer-tracing/src/main/java/io/micrometer/tracing/Span.java

 */
- @Override
 Span event(String value);


MissingOverride: event implements method in SpanCustomizer; expected @OverRide
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:10Z

micrometer-tracing/src/main/java/io/micrometer/tracing/Span.java

 */
- @Override
 Span name(String name);


MissingOverride: name implements method in SpanCustomizer; expected @OverRide
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:12Z

micrometer-tracing/src/main/java/io/micrometer/tracing/Span.java

 */
- @Override
 Span tag(String key, String value);


MissingOverride: tag implements method in SpanCustomizer; expected @OverRide
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:13Z

...n/java/io/micrometer/tracing/reporter/wavefront/WavefrontSpringObservabilitySpanHandler.java

+ }
+
+ // https://github.com/wavefrontHQ/wavefront-proxy/blob/3dd1fa11711a04de2d9d418e2269f0f9fb464f36/proxy/src/main/java/com/wavefront/agent/listeners/tracing/ZipkinPortUnificationHandler.java#L397-L402
+ static List<SpanLog> convertAnnotationsToSpanLogs(FinishedSpan span) {


MixedMutabilityReturnType: This method returns both mutable and immutable collections or maps from different paths. This may be confusing for users of the method.
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:14Z

...-tracing-bridge-otel/src/main/java/io/micrometer/tracing/otel/bridge/OtelBaggageInScope.java

+ close();
+ Entry entry = entry();
+ Scope scope = Baggage.builder().put(entry.getKey(), entry.getValue(), entry.getMetadata()).build()
+ .makeCurrent();


MustBeClosedChecker: The result of this method must be closed.
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:15Z

...-tracing-bridge-otel/src/main/java/io/micrometer/tracing/otel/bridge/OtelBaggageInScope.java

+ baggage = Baggage.builder().put(entry().getKey(), value, entry().getMetadata()).build();
+ }
+ Context withBaggage = current.with(baggage);
+ this.scope.set(withBaggage.makeCurrent());


MustBeClosedChecker: The result of this method must be closed.
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:16Z

...ing-bridge-otel/src/main/java/io/micrometer/tracing/otel/bridge/OtelCurrentTraceContext.java

+ (key, baggageEntry) -> baggageBuilder.put(key, baggageEntry.getValue(), baggageEntry.getMetadata()));
+ Baggage updatedBaggage = baggageBuilder.build();
+
+ io.opentelemetry.context.Scope attach = old.with(fromContext).with(updatedBaggage).makeCurrent();


MustBeClosedChecker: The result of this method must be closed.
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:17Z

...ter-tracing-bridge-otel/src/main/java/io/micrometer/tracing/otel/bridge/OtelSpanInScope.java

+ OtelSpanInScope(OtelSpan sleuthSpan, io.opentelemetry.api.trace.Span otelSpan) {
+ this.sleuthSpan = sleuthSpan;
+ this.otelSpan = otelSpan;
+ this.delegate = otelSpan.makeCurrent();


MustBeClosedChecker: The result of this method must be closed.
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:18Z

...crometer-tracing-bridge-otel/src/main/java/io/micrometer/tracing/otel/bridge/OtelTracer.java

+ @Override
+ public ScopedSpan startScopedSpan(String name) {
+ io.opentelemetry.api.trace.Span span = this.tracer.spanBuilder(name).startSpan();
+ return new OtelScopedSpan(span, span.makeCurrent());


MustBeClosedChecker: The result of this method must be closed.
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:20Z

micrometer-tracing/src/main/java/io/micrometer/tracing/handler/TracingRecordingHandler.java

+ (clazz) -> new TracingContext());
+ }
+
+ @Nullable


NullableVoid: void-returning methods should not be annotated with @nullable, since they cannot return null
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:21Z

...idge-brave/src/main/java/io/micrometer/tracing/brave/bridge/CompositePropagationFactory.java

+ continue;
+ }
+ TraceContextOrSamplingFlags extract = propagator.extractor(getter).extract(request);
+ if (extract != TraceContextOrSamplingFlags.EMPTY) {


ReferenceEquality: Comparison using reference equality instead of value equality
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:22Z

...idge-brave/src/main/java/io/micrometer/tracing/brave/bridge/CompositePropagationFactory.java

+ continue;
+ }
+ TraceContext decorate = entry.getKey().decorate(context);
+ if (decorate != context) {


ReferenceEquality: Comparison using reference equality instead of value equality
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:23Z

...er-tracing-bridge-brave/src/main/java/io/micrometer/tracing/brave/bridge/W3CPropagation.java

+
+ List<AbstractMap.SimpleEntry<BaggageInScope, String>> addBaggageToContext(String baggageHeader) {
+ List<AbstractMap.SimpleEntry<BaggageInScope, String>> pairs = new ArrayList<>();
+ String[] entries = baggageHeader.split(",");


StringSplitter: String.split(String) has surprising behavior
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:24Z

...idge-otel/src/main/java/io/micrometer/tracing/otel/propagation/BaggageTextMapPropagator.java

+ baggageEntries.forEach(e -> setter.set(c, e.getKey(), e.getValue()));
+ }
+
+ private <C> List<Map.Entry<String, String>> applicableBaggageEntries(C c) {


UnusedVariable: The parameter 'c' is never read.
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:26Z

...ng-reporter-zipkin/src/main/java/io/micrometer/tracing/reporter/zipkin/ZipkinBraveSetup.java

+ return new BraveHttpClientHandler(brave.http.HttpClientHandler.create(httpTracing));
+ }
+
+ private static Consumer<BraveBuildingBlocks> closingFunction(BraveBuildingBlocks braveBuildingBlocks) {


UnusedVariable: The parameter 'braveBuildingBlocks' is never read.
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:27Z

...ing-reporter-zipkin/src/main/java/io/micrometer/tracing/reporter/zipkin/ZipkinOtelSetup.java

+ return new OtelHttpClientHandler(openTelemetrySdk, null, null, SamplerFunction.alwaysSample(), new DefaultHttpClientAttributesExtractor());
+ }
+
+ private static Consumer<OtelBuildingBlocks> closingFunction(OtelBuildingBlocks otelBuildingBlocks) {


UnusedVariable: The parameter 'otelBuildingBlocks' is never read.
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:28Z

micrometer-tracing/src/main/java/io/micrometer/tracing/handler/HttpTracingRecordingHandler.java

+ @Override
+ public void onStart(Timer.Sample sample, CTX event) {
+ Span parentSpan = getTracingContext(event).getSpan();
+ CurrentTraceContext.Scope scope = null;


UnusedVariable: The local variable 'scope' is never read.
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:29Z

...cing-bridge-otel/src/main/java/io/micrometer/tracing/otel/bridge/ArrayListSpanProcessor.java

+
+ @Override
+ public void onEnd(ReadableSpan span) {
+ this.spans.add(span.toSpanData());


INTERFACE_NOT_THREAD_SAFE: Unprotected call to method ReadableSpan.toSpanData() of un-annotated interface io.opentelemetry.sdk.trace.ReadableSpan. Consider annotating the interface with @ThreadSafe or adding a lock.
Reporting because a superclass class io.opentelemetry.sdk.trace.SpanProcessor is annotated @ThreadSafe.
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:30Z

...idge-otel/src/main/java/io/micrometer/tracing/otel/propagation/BaggageTextMapPropagator.java

+ Baggage baggage = builder.build();
+ Context withBaggage = context.with(baggage);
+ if (log.isDebugEnabled()) {
+ log.debug("Will propagate new baggage context for entries " + baggageEntries);


INTERFACE_NOT_THREAD_SAFE: Unprotected call to method InternalLogger.debug(...) of un-annotated interface io.micrometer.core.util.internal.logging.InternalLogger. Consider annotating the interface with @ThreadSafe or adding a lock.
Reporting because a superclass class io.opentelemetry.context.propagation.TextMapPropagator is annotated @ThreadSafe.
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:31Z

...idge-otel/src/main/java/io/micrometer/tracing/otel/propagation/BaggageTextMapPropagator.java

+
+ @Override
+ public <C> void inject(Context context, C c, TextMapSetter<C> setter) {
+ List<Map.Entry<String, String>> baggageEntries = applicableBaggageEntries(c);


INTERFACE_NOT_THREAD_SAFE: Unprotected call to method BaggageManager.getAllBaggage() of un-annotated interface io.micrometer.tracing.BaggageManager. Consider annotating the interface with @ThreadSafe or adding a lock.
Reporting because a superclass class io.opentelemetry.context.propagation.TextMapPropagator is annotated @ThreadSafe.
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:32Z

...ge-otel/src/main/java/io/micrometer/tracing/otel/propagation/CompositeTextMapPropagator.java

+ W3CBaggagePropagator.getInstance()));
+ this.mapping.put(PropagationType.CUSTOM, NoopTextMapPropagator.INSTANCE);
+ if (log.isDebugEnabled()) {
+ log.debug("Registered the following context propagation types " + this.mapping.keySet());


INTERFACE_NOT_THREAD_SAFE: Unprotected call to method InternalLogger.debug(...) of un-annotated interface io.micrometer.core.util.internal.logging.InternalLogger. Consider annotating the interface with @ThreadSafe or adding a lock.
Reporting because a superclass class io.opentelemetry.context.propagation.TextMapPropagator is annotated @ThreadSafe.
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:34Z

...acing-bridge-brave/src/main/java/io/micrometer/tracing/brave/bridge/BraveSpanCustomizer.java

+ }
+
+ static brave.SpanCustomizer toBrave(SpanCustomizer spanCustomizer) {
+ return ((BraveSpanCustomizer) AssertingSpanCustomizer.unwrap(spanCustomizer)).spanCustomizer;


NULL_DEREFERENCE: object returned by unwrap(spanCustomizer) could be null and is dereferenced at line 37.
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:35Z

...micrometer-tracing-bridge-otel/src/main/java/io/micrometer/tracing/otel/bridge/OtelSpan.java

+ }
+
+ static io.opentelemetry.api.trace.Span toOtel(Span span) {
+ return ((OtelSpan) AssertingSpan.unwrap(span)).delegate;


NULL_DEREFERENCE: object returned by unwrap(span) could be null and is dereferenced at line 56.
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:36Z

...eter-tracing/src/main/java/io/micrometer/tracing/handler/DefaultTracingRecordingHandler.java

+ public void onRestore(Timer.Sample sample, Timer.HandlerContext context) {
+ // TODO: check for nulls
+ CurrentTraceContext.Scope scope = this.tracer.currentTraceContext()
+ .maybeScope(getTracingContext(context).getSpan().context());


NULL_DEREFERENCE: object returned by DefaultTracingRecordingHandler.tracer.currentTraceContext() could be null and is dereferenced at line 51.
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:37Z

micrometer-tracing/src/main/java/io/micrometer/tracing/handler/TracingRecordingHandler.java

+ return;
+ }
+ CurrentTraceContext.Scope scope = getTracer().currentTraceContext()
+ .maybeScope(span.context());


NULL_DEREFERENCE: object returned by getTracer().currentTraceContext() could be null and is dereferenced at line 48.
(at-me in a reply with help or ignore)

sonatype-lift · 2021-11-15T12:29:38Z

...er-tracing-bridge-brave/src/main/java/io/micrometer/tracing/brave/bridge/W3CPropagation.java

+ if (baggage == null) {
+ return;
+ }
+ String traceState = baggage.get(BraveTraceContext.fromBrave(context));


RESOURCE_LEAK: resource of type io.micrometer.tracing.brave.bridge.BraveBaggageInScope acquired by call to getBaggage(...) at line 209 is not released after line 214.
(at-me in a reply with help or ignore)

marcingrzejszczak added 9 commits November 10, 2021 16:34

WIP on adding wavefront, brave, otel and zipkin

bcba73a

Moved most of the code

d8356c0

Added tests

3fc7964

Added brave & otel local sample setup for zipkin

0678dbf

Fixed setup

ea2caf8

Bumped libs

8aec392

Fixed javadoc issues

5e42b01

Updated dependencies

18a8a80

Added milestone & snapshot repo

6ed19bc

sonatype-lift bot reviewed Nov 15, 2021

View reviewed changes

Upgraded wrapper

03fe909

marcingrzejszczak merged commit 1f45dad into main Nov 15, 2021

marcingrzejszczak deleted the all_tracing branch November 15, 2021 14:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Brave, OTel, Zipkin & Wavefront #1

Added Brave, OTel, Zipkin & Wavefront #1

marcingrzejszczak commented Nov 12, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021

sonatype-lift bot Nov 15, 2021


		private final io.opentelemetry.api.trace.SpanBuilder delegate;

		private final List<String> annotations = new LinkedList<>();


		private static final Map<String, BaggageInScope> CACHE = new ConcurrentHashMap<>();

		public Map<String, String> getAllBaggage() {

Added Brave, OTel, Zipkin & Wavefront #1

Added Brave, OTel, Zipkin & Wavefront #1

Conversation

marcingrzejszczak commented Nov 12, 2021

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment

sonatype-lift bot Nov 15, 2021

Choose a reason for hiding this comment