-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor #24
refactor #24
Conversation
@jonschlinkert just a quick note.
Any chance we could move braces.toRegex out to a new pkg? Or just add a quick README notice on usage — no need for a new pkg. |
Are you saying we should drop regex support from braces? How much of the 300k is safe-regex (the library that checks for catastrophic backtracking to prevent DDoS)? If this gets too complicated I'll have to plan time in the future to work on this. |
@jonschlinkert here's
|
@jonschlinkert as far as I see from the readme there's no support for |
YAY! 🌈 Any ETA on the release? |
it's done. I just need to wrap it up and release. probably today |
Great to see one less tool (appveyor). |
@paulmillr FWIW I use a tool to generate documentation, the badges are in a template, so they'll automatically be updated. The appveyor badge is excluded if there is no |
@jonschlinkert ping! |
What are you pinging about @paulmillr? |
Let's release it 😃 |
Are you volunteering to do the docs and changelog? :) |
Working on |
I’ve prepared new builds — Chokidar is 1/8th of previous size and feels super lean now. Can’t wait on getting these packages released! |
I'll be working on it this weekend. |
@paulmillr how's everything working out? |
@jonschlinkert it’s awesome, we’re fixing tests across platforms and waiting for node 8.16 |
I hope I didn't break anything! |
No description provided.