Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the scrollview animation issue and added some helpers. #2

Merged
merged 6 commits into from
Aug 13, 2011

Conversation

foxyblocks
Copy link
Contributor

I found that the animation issue could be fixed if you increase the contentInset.bottom instead of shrinking the height.

I also added a couple extra things that I've found helpful.

@michaeltyson
Copy link
Owner

Cool! I'll take a look at it soon

Michael Tyson | atastypixel.com (https://atastypixel.com/)
A Tasty Pixel: Delectable apps for iPhone and Mac

Loopy 2 (https://loopyapp.com): A saavy, sophisticated, tactile new looper that reinvents the formula. Make music on your iPhone from anything. Coming soon.

Subscribe to our newsletter (https://atastypixel.com/newsletter)

e: [email protected] (mailto:[email protected])

aim: mikerusselltyson
twitter: MichaelTyson

On Monday, 6 June 2011 at 14:50, webartisan wrote:

I found that the animation issue could be fixed if you increase the contentInset.bottom instead of shrinking the height.

I also added a couple extra things that I've found helpful.

Reply to this email directly or view it on GitHub:
#2

-removed the conditions that check for original content inset before doing anything. These made since when the height was being adjusted, but not anymore. They were just causing problems.
-I don't know if it was originally like this but I'm going to fix it anyway.
@foxyblocks
Copy link
Contributor Author

I fixed a couple of issues that I found. The contentInsets weren't being reset when the keyboard was hiding. Also the scrollview should now support fields that are inside a subview of the scrollview rather than just direct child fields.

Also my 3rd commit has a confusing comment, I meant to say that I changed it back to pin-stripe. I think in my last push I changed it to white and it looked kind of ugly. Not all that important though.

michaeltyson added a commit that referenced this pull request Aug 13, 2011
Fixed the scrollview animation issue and added some helpers.
@michaeltyson michaeltyson merged commit d6ebc02 into michaeltyson:master Aug 13, 2011
@michaeltyson
Copy link
Owner

Thanks heaps for this! Sorry it took me so long to get my act together and merge it in =)
Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants