Handle cases when auth groups are unset #353
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdohnal
force-pushed
the
auth-print-group-none
branch
from
2701790
to
203e31c
Compare
michaelrsweet
requested changes
Mar 18, 2024
Currently, pappl based applications require authentication every time for any request if authentication module is set, even if authentication group(s) is set to `None`. With this PR, admin can set admin and print group to `None`. Every admin action is allowed if admin group is `None`. If the connection is local, no group is set and we are missing authentication field, use `requesting-user-name`. This allows smooth printing to the printer application via CUPS when printer application uses PAM module to protect against simple attacks.
zdohnal
force-pushed
the
auth-print-group-none
branch
from
203e31c
to
2275160
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, pappl based applications require authentication every time for any request if authentication module is set, even if authentication group(s) is set to
None.With this PR, admin can set admin and print group to
None. Every admin action is allowed if admin group isNone. For printing jobs, Validate-Job, Print-Job, Create-Job are allowed, Send-Document if the requesting client is owner of the job - value ofrequesting-user-nameis used as default value, in case authorization field does not contain it.This allows smooth printing to the printer application via CUPS when printer application uses PAM module to protect against simple attacks.