use "from" location to determine preferred distance units #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only a fix to the type checking - behavior is the same.
There's an unfortunate redundant fetch to the pelias endpoint to populate the POI. I'd like to address this in future work, probably by replacing POI with Place, but POI is used all over the place so I'd want to do it gradually as I have a better understanding of how its used. In the meanwhile I think this extra request is worth getting the units right for people.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's all km all the time. As much as I'd like for that to be true, for now I think I need to accommodate the whimsical units of my home.
So now we choose units based on the preferred units of the "from" location.