Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

009_paper_GR2020: Improve arguments passed to 'box' parameter #18

Conversation

yvonnefroehlich
Copy link
Contributor

@yvonnefroehlich yvonnefroehlich commented Jan 29, 2024

This PR aims to improve the arguments passed to the box parameter of Figure.colorbar and Figure.legend. Please indicate if you prefer another appearance of the box fill or outline.

gitnotebook: https://gitnotebooks.com/michaelgrund/GMT-plotting/pull/18

@@ -574,7 +574,7 @@
" FONT_LABEL = '6',\n",
" MAP_FRAME_PEN = '0.4p'):\n",
"\n",
" fig.legend(position = 'JBR+jBR+o0.1c', box = '+plinen+glinen+gwhite+p0.5p,black')\n",
" fig.legend(position = 'JBR+jBR+o0.1c', box = '+gwhite+p0.5p,black')\n",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please indicate if you prefer other fill and pen colors (and a semi-transparency for the fill).

@smith-kyle
Copy link

I noticed you all aren't using a notebook review tool and wanted to invite you to review this pull request with GitNotebooks: https://gitnotebooks.com/michaelgrund/GMT-plotting/pull/18

It lets you do things like comment on rendered markdown and code cells, so might be an easy win for your PR reviews.

@yvonnefroehlich
Copy link
Contributor Author

I noticed you all aren't using a notebook review tool and wanted to invite you to review this pull request with GitNotebooks: https://gitnotebooks.com/michaelgrund/GMT-plotting/pull/18

It lets you do things like comment on rendered markdown and code cells, so might be an easy win for your PR reviews.

@smith-kyle thanks for pointing this out 🙂. It sounds interesting and useful. I will take a look at this in more detail.

@michaelgrund michaelgrund merged commit 08b888e into michaelgrund:main Apr 26, 2024
@yvonnefroehlich yvonnefroehlich deleted the improve-box-arg-009_paper_GR2020 branch April 26, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants