Fix the reported line/column for syntax errors. #353
Merged
+18
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported at decaffeinate/decaffeinate#54, CoffeeScriptRedux syntax errors always point to line 1 column 1. This is very annoying when trying to figure out what part of the file it actually can’t parse. This updates the peg override to match the new signature for `peg$computePosDetails` which now takes a `pos` argument.
|
Yeah, unfortunately this hack is the most fragile part of the compiler (see the comment above). Thanks for fixing it. I wish we had a better way. |
michaelficarra
added a commit
that referenced
this pull request
Sep 23, 2015
Fix the reported line/column for syntax errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported at decaffeinate/decaffeinate#54, CoffeeScriptRedux syntax errors always point to line 1 column 1. This is very annoying when trying to figure out what part of the file it actually can’t parse. This updates the peg override to match the new signature for
peg$computePosDetailswhich now takes aposargument.