Fix duplicate vars at top level #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase. |
To see the problem this patch fixes, look at the first line of lib/cli.js: ```js var $0, $0, ... ``` The Program node handler was attempting to deduplicate with `nub`, but doing so over a list of JS.Identifiers, not a list of plain strings. Since most callers of `declarationsNeededRecursive` are more interested in the set of names than the identifier nodes, I changed it to do that.
|
Rebased and recompiled |
michaelficarra
added a commit
that referenced
this pull request
May 28, 2015
Fix duplicate vars at top level
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To see the problem this patch fixes, look at the first line of lib/cli.js:
The Program node handler was attempting to deduplicate with
nub, butdoing so over a list of JS.Identifiers, not a list of plain strings.
Since most callers of
declarationsNeededRecursiveare more interestedin the set of names than the identifier nodes, I changed it to do that.