Add save_capture_as_bands() method. Add out_data_type parameter. #154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scope of this PR was a little broader than expected.
The unanticipated challenge when allowing multiple output data types is that handling the
img_type is None
case creates too many logical branches and the standardif else
clutter for no real benefit. The simplest thing to do was changeimg_type
from akwarg
to a positional argument. Forcing the choice works because there are only 2 potential outputs, and handling theNone
case with available data just felt like it added confusion especially in the higher level ImageSet.This PR:
Capture.create_aligned_capture()
to acceptimg_type
as a positional argument. Simplify radiance/reflectance logic.Capture.save_capture_as_bands()
to meet the original intent. This includes output data type handling, and simplified logic depending on whether user passes'radiance'
or 'reflectance'
value.ImageSet
to accomodate output data type parameter. Also updateimg_type
to positional argument to matchCapture
usage. Some docstring improvements.