Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace Option<(&'a str, &'a str)> with HeaderMap #101

Merged
merged 1 commit into from
May 8, 2023

Conversation

mgrachev
Copy link
Owner

@mgrachev mgrachev commented May 8, 2023

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • Tests for the changes have been added (for bug fixes / features).

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.09 🎉

Comparison is base (efb2442) 94.22% compared to head (4fdf288) 94.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   94.22%   94.32%   +0.09%     
==========================================
  Files          12       13       +1     
  Lines         641      652      +11     
==========================================
+ Hits          604      615      +11     
  Misses         37       37              
Impacted Files Coverage Δ
src/lib.rs 94.27% <ø> (ø)
src/http_client/headers.rs 100.00% <100.00%> (ø)
src/http_client/mod.rs 100.00% <100.00%> (ø)
src/http_client/reqwest.rs 88.88% <100.00%> (ø)
src/http_client/ureq.rs 100.00% <100.00%> (ø)
src/registry/github.rs 89.47% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mgrachev mgrachev force-pushed the header-map branch 2 times, most recently from e6f279d to 4fdf288 Compare May 8, 2023 10:52
@mgrachev mgrachev merged commit 73c9f1c into main May 8, 2023
@mgrachev mgrachev deleted the header-map branch May 8, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants