Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic return type extension for \Drupal::service #190

Closed
mglaman opened this issue Jul 16, 2021 · 3 comments · Fixed by #209
Closed

Dynamic return type extension for \Drupal::service #190

mglaman opened this issue Jul 16, 2021 · 3 comments · Fixed by #209

Comments

@mglaman
Copy link
Owner

mglaman commented Jul 16, 2021 •
edited

We have a dynamic return type extension for the service container, but only on the ContainerInterface. It might not be reading that \Drupal::service calls \Drupal::getContainer()->get.

Resolves the following Upgrade Status issues:

Fixes #192 #116
@mglaman
Copy link
Owner Author

mglaman commented Sep 22, 2021

Related to #116

@mglaman
Copy link
Owner Author

mglaman commented Sep 29, 2021

This may have been fixed in #205

@mglaman mglaman pinned this issue Sep 29, 2021
@mglaman
Copy link
Owner Author

mglaman commented Oct 6, 2021

Not fixed, needs its own return type extension.

@mglaman mglaman mentioned this issue Oct 6, 2021
Merged
This was referenced Oct 6, 2021
Closed
Closed
Closed
@mglaman mglaman unpinned this issue Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return type extension for \Drupal::service calls mglaman/phpstan-drupal
1 participant
@mglaman