-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not detect depricated \Drupal::service('user.private_tempstore') #242
Comments
Let me get a new release of drupal-check out, this will be fixed by the latest phpstan-drupal release: https://github.com/mglaman/phpstan-drupal/releases/tag/0.12.15 |
@lostcarpark try running |
Thank you for fixing this. I've upgraded my own module to D9, so no sure I can test this. |
I'll just close it and see if anyone else reports it. Sorry it wasn't available before! |
How is drupal-check installed?
drupal-check is installed globally via Composer
Environment:
Describe the bug
My module had a number of instances referencing \Drupal::service('user.private_tempstore'), which is depricated in D9, but were not reported by drupal-check.
These needed to be updated to \Drupal::service('tempstore.private').
These could be tricky to detect, since the service name is a string, but I suspect a lot of cases could be caught by checking for the text above. The presence of a string containing 'user.private_tempstore' should at least generate a warning.
Console output
N/A, since case not caught by drupal-check.
The text was updated successfully, but these errors were encountered: