Add support for checking multiple paths (implements #63) #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinodell
commented
May 7, 2019
colinodell
commented
May 7, 2019
colinodell
commented
May 7, 2019
mglaman
requested changes
May 7, 2019
There was a problem hiding this comment.
The only thing we are missing is some test coverage otherwise this looks fine!
Can you take the test_drupal job in the .circleci/config.yaml and add
- run:
name: Phar - Run against multiple paths
command: |
php drupal-check.phar /tmp/drupal/core/install.php /tmp/drupal/core/modules/dynamic_page_cache -vvv
Maybe after name: Phar - Run against a module.
|
Thanks for the feedback! I have added that additional test. I also made another small tweak to the Usage:
```
- drupal-check [OPTIONS] [DIR]
+ drupal-check [OPTIONS] [DIRS]
```
Arguments:
* `OPTIONS` - See "Options" for allowed values. Specify multiples in sequence, e.g. `-ad`.
-* `DIR` - One or more directories within the root of a Drupal project.
+* `DIRS` - One or more directories within the root of a Drupal project.Changes have been squashed and pushed for your review. |
mglaman
approved these changes
May 8, 2019
|
Thanks so much for this, it's great. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CommandHelperalready supports multiple paths - we just need to modify our code to provide them.I'll leave a couple of additional inline comments to explain some of the changes I made.
Fixes #63