Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Check multiple paths #63

Closed
colinodell opened this issue May 6, 2019 · 1 comment · Fixed by #67
Closed

Feature Request: Check multiple paths #63

colinodell opened this issue May 6, 2019 · 1 comment · Fixed by #67
Labels
enhancement New feature or request

Comments

@colinodell
Copy link
Contributor

colinodell commented May 6, 2019

I would like the ability to check multiple paths at a time.

Currently, drupal-check only accepts a single path. If I want to check multiple paths I need to run this multiple times. For example:

drupal-check web/modules/contrib
drupal-check web/modules/custom
drupal-check web/themes/contrib
drupal-check web/themes/custom

This poses two challenges:

  1. CI runners will generally stop after a command returns a non-zero exit code. So if any deprecations are found in web/modules/contrib then none of my 3 other paths will be checked.
  2. The results for each command will be scattered in 4 places in the output - I'd rather see one single list of errors with a final error count at the very end of the output.
@colinodell
Copy link
Contributor Author

In the meantime, this workaround seems to solve the first challenge (but not the second):

status=0
drupal-check web/modules/contrib || status=1
drupal-check web/modules/custom || status=1
drupal-check web/themes/contrib || status=1
drupal-check web/themes/custom || status=1
exit $status

@mglaman mglaman added the enhancement New feature or request label May 7, 2019
@mglaman mglaman added this to Needs triage in Issue triage via automation May 7, 2019
@mglaman mglaman moved this from Needs triage to Low priority in Issue triage May 7, 2019
Issue triage automation moved this from Low priority to Closed May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Issue triage
  
Closed
Development

Successfully merging a pull request may close this issue.

2 participants