Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop creating inaccessible global constants "0" and "1" #73

Merged
merged 1 commit into from
Jul 15, 2017
Merged

Stop creating inaccessible global constants "0" and "1" #73

merged 1 commit into from
Jul 15, 2017

Conversation

TysonAndre
Copy link
Contributor

This was a side effect of the macro that was used to declare constants
for the values of the stringified version of the constant name.

get_defined_constants(true)['mosquitto'] can be used to show the old
constants (["MOSQ_LOG_INFO"] => 1, ..., "0" => 0, "1" => 1])

The presence of those global constants causes sanity checks of what is a valid
constant name to fail in some applications using reflection.

This was a side effect of the macro that was used to declare constants
for the values of the stringified version of the constant name.

`get_defined_constants(true)['mosquitto']` can be used to show the old
constants (`["MOSQ_LOG_INFO"] => 1, ..., "0" => 0, "1" => 1]`)
@remicollet
Copy link
Contributor

@TysonAndre thanks for the fix

I confirm it fixes the issue raised on phan by bad constant definitions

Please merge

@mgdm mgdm merged commit 35d77cd into mgdm:master Jul 15, 2017
@mgdm
Copy link
Owner

mgdm commented Jul 15, 2017

Thanks @TysonAndre and @remicollet!

@TysonAndre TysonAndre deleted the fix-inaccessible-global-const branch February 5, 2019 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants