add onPublish callback method #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 31, 2015 19:43
| mosquitto_message_object *message_object; | ||
| zval *retval_ptr = NULL, *message_zval = NULL; | ||
| zval **params[1]; | ||
| mosquitto_client_object *object = (mosquitto_client_object *) client_obj; |
There was a problem hiding this comment.
Would you mind putting the indentation here back how it was? I use tabs, not spaces, in C code. I can do it if not.
There was a problem hiding this comment.
I am very sorry I forgot the damn IDE, could I change it back?
There was a problem hiding this comment.
No problem, I did it before I merged it. Thanks!
On 6 Sep 2015, at 16:44, acrazing [email protected] wrote:
In mosquitto.c:
@@ -1021,39 +1056,75 @@ PHP_MOSQUITTO_API void php_mosquitto_log_callback(struct mosquitto *mosq, void *
PHP_MOSQUITTO_API void php_mosquitto_message_callback(struct mosquitto *mosq, void *client_obj, const struct mosquitto_message *message)
{
- mosquitto_client_object *object = (mosquitto_client_object *) client_obj;
- mosquitto_message_object *message_object;
- zval *retval_ptr = NULL, *message_zval = NULL;
- zval **params[1];
- mosquitto_client_object *object = (mosquitto_client_object *) client_obj;
I am very sorry I forgot the damn IDE, could I change it back?—
Reply to this email directly or view it on GitHub.
|
Well spotted, thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i found that the method
mosquitto_publishis asynchronous, so, the calllback is required!