Fix windows build #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
these are fixes for windows, here you can touch the snapshot https://windows.php.net/downloads/pecl/snaps/mosquitto/0.2.2/ . Unfortunately I lack on time to test it with the mosquitto servce. The vc11 builds should be fine, even with 5.6. The vc9 build is where I doubt as building the libmosquitto seems to not to support vc9 and it's hardcoded to support Windows starting with Vista (that's why i've asked on PECL about it). I still could trick it to build with vc9, we'll see whether it's ok. Note that to test you'll need to get the corresponding pthreads build available here https://windows.php.net/downloads/pecl/deps/ (needed by libmosquitto).
Regards
Anatol