Make QoS and retain optional on publish

mgdm · Oct 20, 2013 · adac167 · adac167
1 parent 4ea1124
commit adac167
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -91,8 +91,8 @@ disconnection from the broker. Must be called before connect().
 | --- | --- | ---- |
 | topic | string | The topic on which to publish the will. |
 | payload | string | The data to send. |
-| qos | int | Integer 0, 1, or 2 indicating the Quality of Service to be used. |
-| retain | boolean | If true, the message will be retained. |
+| qos | int | Optional. Default 0. Integer 0, 1, or 2 indicating the Quality of Service to be used. |
+| retain | boolean | Optional. Default false. If true, the message will be retained. |
 
 #### clearWill
 

diff --git a/mosquitto.c b/mosquitto.c
@@ -397,12 +397,12 @@ PHP_METHOD(Mosquitto_Client, publish)
 {
  mosquitto_client_object *object;
  int mid, topic_len, payload_len, retval;
- long qos;
- zend_bool retain;
+ long qos = 0;
+ zend_bool retain = 0;
  char *topic, *payload;
 
  PHP_MOSQUITTO_ERROR_HANDLING();
- if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "sslb",
+ if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "ss|lb",
  &topic, &topic_len, &payload, &payload_len, &qos, &retain) == FAILURE) {
  PHP_MOSQUITTO_RESTORE_ERRORS();
  return;