Spaces are accepted before @ sign

[dcarniel]

Hi,

I noticed that spaces are accepted before the @ sign of the email address, values such as "jo [email protected]", "john. [email protected]" or "john.doe @example.com" are not flagged as invalid, here is an example of result obtained:

jo [email protected]:
{
  "valid": true,
  "validators": {
    "regex": {
      "valid": true
    },
    "typo": {
      "valid": true
    },
    "disposable": {
      "valid": true
    },
    "mx": {
      "valid": true
    },
    "smtp": {
      "valid": true
    }
  }
}

This test is done with the following code:

async function checkEmail( email: string ) {
  const valid = await validate({
    email: email,
    sender: email,
    validateRegex: true,
    validateMx: true,
    validateTypo: true,
    validateDisposable: true,
    validateSMTP: false,
  });
  logger.error( `${email}:\n${JSON.stringify( valid, null, 2)}` );
}

I would expect it to fail at the regexp stage. For sure an address with a space in that part is refused by email servers.

Let me known if you need any more details.
Denis

[dcarniel]

I also have another corner case which I would expect be caught: [email protected]. is actually reported as correct if the typo check is disabled.
I would expect this to be caught by the regexp validation. It is very annoying as many modern browsers add a period when pressing space twice. I can easily trim the input but that won't remove the trailing dot.

[mfbx9da4]

Checking for spaces is beyond this

The philosophy of this lib is to be really light on validating the format of an email as that notoriously produces a lot of false alarms. Spaces are actually valid I believe in some cases, so I won't be adding that. If you want just regex I recommend validator.

The latter complaint is fair though. This lib should definitely validate that the email should not end with ..

deep-email-validator/src/regex/regex.ts

Lines 10 to 13 in 7f34d7b

	const [domain] = split.slice(-1)
	if (domain.indexOf('.') === -1) {
	return 'Must contain a "." after the "@".'
	}

Should add

   if (domain.endsWith('.')) {
      return 'Must not end with "."'
    }

[dcarniel-evorra]

I agree that you don't want to generate too many false alarms. Though I'd expect that spaces are only before or right after characters such as <> or "" that mark a readable name associated with the actual email.
There certainly should not be any spaces in the actual email part, though I must admit I'm not sure to put that together in a reliable RegExp ;).

[conradkirschner]

I also have another corner case which I would expect be caught: [email protected]. is actually reported as correct if the typo check is disabled. I would expect this to be caught by the regexp validation. It is very annoying as many modern browsers add a period when pressing space twice. I can easily trim the input but that won't remove the trailing dot.

https://stackoverflow.com/a/49153802

Isn't is a valid domain? So email should also be valid in this case.