Add typing and refactor code to simplify #27
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK so there were a couple of functional changes I made:
room_temperature
a property instead of a functionEvery other change was to reduce the code complexity, reuse code where possible, etc. You can see in the tests that the values don't change in spite of the refactoring which was why I added the tests first
Renamed variables and raising an Exception will require changes in the integration to support which we can address when we bump the dependency upstream.