Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for pyeight.eight and pyeight.user #25

Merged
merged 15 commits into from
May 20, 2022
Merged

Conversation

raman325
Copy link
Contributor

@raman325 raman325 commented May 9, 2022

I made minimal changes here to get pylint to pass. Next step after merge would be to simplify some of the logic, to add type hints, and to improve coverage

@raman325 raman325 force-pushed the tests branch 2 times, most recently from 57f5465 to d75b29c Compare May 10, 2022 00:49
@raman325 raman325 changed the title Add tests and automatic test/formatting checking Add tests May 10, 2022
@raman325 raman325 changed the title Add tests Add tests for pyeight.eight May 10, 2022
@raman325 raman325 changed the title Add tests for pyeight.eight Add tests for pyeight.eight and pyeight.user May 10, 2022
pyeight/user.py Outdated Show resolved Hide resolved
@raman325
Copy link
Contributor Author

raman325 commented May 11, 2022

I also added another round of tests to improve coverage and this is my final list commit on this PR. This will help ensure that when I make a bunch of changes to the code (already ready and I am testing it against these tests), the test case changes should be minimal and deliberate in that I think the changed behavior is the better behavior in those cases

@mezz64
Copy link
Owner

mezz64 commented May 19, 2022

This all looks good and functionality tests out OK in my dev environment. Only thing I'd ask you to do before I merge is change your email in the test_eight.py and test_user.py files to the mock email ([email protected]) you have defined in the fixtures.

@raman325
Copy link
Contributor Author

good call, that was meant to be a placeholder and I certainly don't want my email in there 🙂

tests/test_eight.py Outdated Show resolved Hide resolved
tests/test_eight.py Outdated Show resolved Hide resolved
tests/test_user.py Outdated Show resolved Hide resolved
@mezz64
Copy link
Owner

mezz64 commented May 19, 2022

good call, that was meant to be a placeholder and I certainly don't want my email in there 🙂

I figured. There are still a few more instances. I marked them in review so you can find them easily.

@raman325
Copy link
Contributor Author

thanks forgot to hit save before committing 🤦🏾

@mezz64 mezz64 merged commit 9cbaaa0 into mezz64:master May 20, 2022
@raman325 raman325 deleted the tests branch May 20, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants