Fix MA0099 for default values in attributes when using Roslyn4.4 or b…

…elow (#526)
meziantou · May 11, 2023 · da94855 · da94855
1 parent 3b518d8
commit da94855
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 1 deletion.
diff --git a/Directory.Build.targets b/Directory.Build.targets
@@ -48,7 +48,7 @@
  <PackageReference Update="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.5.0" />
  </ItemGroup>
  <PropertyGroup>
- <DefineConstants>$(DefineConstants);ROSLYN4_4;ROSLYN_4_2_OR_GREATER;ROSLYN_4_4_OR_GREATER</DefineConstants>
+ <DefineConstants>$(DefineConstants);ROSLYN4_4;ROSLYN_4_2_OR_GREATER;ROSLYN_4_4_OR_GREATER;ROSLYN_4_5_OR_GREATER</DefineConstants>
  <DefineConstants>$(DefineConstants);CSHARP9_OR_GREATER;CSHARP10_OR_GREATER;CSHARP11_OR_GREATER</DefineConstants>
  <NoWarn>$(NoWarn);CS0618</NoWarn>
  </PropertyGroup>

diff --git a/src/Meziantou.Analyzer/Rules/DoNotUseZeroToInitializeAnEnumValue.cs b/src/Meziantou.Analyzer/Rules/DoNotUseZeroToInitializeAnEnumValue.cs
@@ -43,6 +43,11 @@ private static void AnalyzeConversion(OperationAnalysisContext context)
  if (operation.Parent is IArgumentOperation { IsImplicit: true })
  return;
 
+#if !ROSLYN4_5_OR_GREATER
+ if (operation.Syntax.IsKind(Microsoft.CodeAnalysis.CSharp.SyntaxKind.Attribute))
+ return;
+#endif
+
  if (operation.ConstantValue is { HasValue: true, Value: not null and var value } && IsZero(enumType, value))
  {
  context.ReportDiagnostic(s_rule, operation, operation.Type.ToDisplayString(SymbolDisplayFormat.CSharpShortErrorMessageFormat));

diff --git a/tests/Meziantou.Analyzer.Test/Rules/DoNotUseZeroToInitializeAnEnumValueTests.cs b/tests/Meziantou.Analyzer.Test/Rules/DoNotUseZeroToInitializeAnEnumValueTests.cs
@@ -364,6 +364,38 @@ void A(MyEnum a = MyEnum.B)
  A();
  }
 }
+""")
+ .ValidateAsync();
+ }
+
+ [Fact]
+ [Trait("Issue", "https://github.com/meziantou/Meziantou.Analyzer/issues/525")]
+ public async Task ImplicitParameterInAttribute()
+ {
+ await CreateProjectBuilder()
+ .WithSourceCode($$"""
+using System;
+
+public enum MyEnum
+{
+ None = 0,
+ Some = 1,
+}
+
+[AttributeUsage(AttributeTargets.All, AllowMultiple = true)]
+public class MyAttribute : Attribute
+{
+ public MyAttribute(MyEnum bar = MyEnum.None) { }
+}
+
+[MyAttribute]
+[MyAttribute(MyEnum.None)]
+[MyAttribute(MyEnum.Some)]
+[MyAttribute([|0|])]
+public class MyClass
+{
+ public MyClass(MyEnum foo = MyEnum.None) { }
+}
 """)
  .ValidateAsync();
  }