Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

870 remove get consolidated #837

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

870 remove get consolidated #837

wants to merge 2 commits into from

Conversation

leite08
Copy link
Member

@leite08 leite08 commented Aug 26, 2023 •
edited
Loading

Ref. metriport/metriport-internal#870

Dependencies

Description

⚠️ IMPORTANT⚠️

  • The UI uses GET /consolidated to load FHIR resources, might need to leave as is, maybe just remove from docs?

Notes:

  • Remove POST /consolidated
  • Remove GET /consolidated
    • Move it to internal routes
  • Remove the respective function from the SDK
  • Add Lerna "ignore" option to package scripts to allow release of individual packages

Release Plan

  • define when this can be merged and communicate it to customers
  • update lib version on NPM
  • merge this

@leite08 leite08 requested a review from a team as a code owner August 26, 2023 23:56
@leite08 leite08 mentioned this pull request Aug 29, 2023
Merged
3 tasks
@leite08 leite08 force-pushed the 870-move-get-consolidated branch 2 times, most recently from e26103d to 66c0bfd Compare August 29, 2023 02:37
@leite08 leite08 changed the base branch from develop to 407-move-post-consolidated-to-put August 29, 2023 02:37
Base automatically changed from 407-move-post-consolidated-to-put to develop August 29, 2023 13:36
@leite08
Copy link
Member Author

leite08 commented Aug 30, 2023 •
edited
Loading

Waiting until Sep 10th to merge this - confirm with @Goncharo before doing so.

@leite08 leite08 marked this pull request as draft August 30, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Orta21 Orta21 Orta21 approved these changes

@Goncharo Goncharo Awaiting requested review from Goncharo Goncharo will be requested when the pull request is marked ready for review Goncharo is a code owner

@RamilGaripov RamilGaripov Awaiting requested review from RamilGaripov RamilGaripov will be requested when the pull request is marked ready for review RamilGaripov is a code owner

@jonahkaye jonahkaye Awaiting requested review from jonahkaye jonahkaye will be requested when the pull request is marked ready for review jonahkaye is a code owner

@thomasyopes thomasyopes Awaiting requested review from thomasyopes thomasyopes will be requested when the pull request is marked ready for review thomasyopes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leite08 @Orta21