Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

963 fix getProviderDataForType #799

Merged
merged 7 commits into from
Aug 17, 2023
Merged

963 fix getProviderDataForType #799

merged 7 commits into from
Aug 17, 2023

Conversation

leite08
Copy link
Member

@leite08 leite08 commented Aug 17, 2023

Ref: https://github.com/metriport/metriport-internal/issues/963

Dependencies

Description

Fixes the issue at getProviderDataForType - context

Release Plan

  • nothing special

RamilGaripov and others added 7 commits August 15, 2023 19:44
@RamilGaripov
Merge pull request #790 from metriport/develop
5da6c52 
RELEASE 2023-08-15
@leite08
Merge pull request #796 from metriport/develop
880282c 
RELEASE 2023-08-12
@leite08
Revert "Merge pull request #796 from metriport/develop"
f48a032 
This reverts commit 880282c, reversing
changes made to 5da6c52.
@leite08
Merge pull request #797 from metriport/revert-963
328a54b 
Revert RELEASE 2023-08-12
@leite08
Revert "Merge pull request #797 from metriport/revert-963"
ffef1a3 
This reverts commit 328a54b, reversing
changes made to 880282c.
@leite08
fix: getProviderDataForType to access provider directly
3905941 
- call the get<type>Data function from the object instead of storing the
function and calling w/o reference to the object

Ref. metriport/metriport-internal#963
@leite08
Merge branch 'reintroduce-963' into reintroduce-963-to-develop
a424aa6
@leite08 leite08 requested a review from a team as a code owner August 17, 2023 03:12
Goncharo
Goncharo approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@Goncharo Goncharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@leite08 leite08 added this pull request to the merge queue Aug 17, 2023
Merged via the queue into develop with commit f43241e Aug 17, 2023
3 checks passed
@leite08 leite08 deleted the reintroduce-963-to-develop branch August 17, 2023 03:25
@leite08 leite08 mentioned this pull request Aug 17, 2023
Merged
@github-actions
Copy link

🎉 This PR is included in version 4.50.2-develop.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 4.50.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Orta21 Orta21 mentioned this pull request Sep 15, 2023
Merged
1 task
@leite08 leite08 mentioned this pull request Oct 4, 2023
Merged
1 task
This was referenced Oct 9, 2023
Merged
Merged
This was referenced Nov 1, 2023
Merged
Merged
Orta21 added a commit that referenced this pull request Nov 25, 2023
@Orta21
feat(api): base mr creation script
1b90204 
Ref. #799
Orta21 added a commit that referenced this pull request Nov 27, 2023
@Orta21
fix(packages): update the channel ports
474bd33 
Ref. #799
@Orta21 Orta21 mentioned this pull request Nov 27, 2023
Merged
1 task
Orta21 added a commit that referenced this pull request Nov 29, 2023
@Orta21
fix(packages): xcpd channels ready shami;
da29cbf 
Ref. #799
Orta21 added a commit that referenced this pull request Nov 29, 2023
@Orta21
fix(packages): remove unnecessary certs
a75ce86 
Ref. #799
leite08 pushed a commit that referenced this pull request Nov 30, 2023
@Orta21 @leite08
fix(packages): update the channel ports
392d59a 
Ref. #799
Orta21 added a commit that referenced this pull request Jul 2, 2024
@Orta21
fix(api): add jsonschema pacakge
c8ec495 
Ref. #799

Signed-off-by: Jorge Orta <[email protected]>
Orta21 added a commit that referenced this pull request Jul 2, 2024
@Orta21
fix(api): add jsonschema pacakge
9b402a9 
Ref. #799

Signed-off-by: Jorge Orta <[email protected]>
Orta21 added a commit that referenced this pull request Jul 2, 2024
@Orta21
fix(api): fix payor
74adb48 
Ref. #799

Signed-off-by: Jorge Orta <[email protected]>
Orta21 added a commit that referenced this pull request Jul 3, 2024
@Orta21
fix(api): oid to url
7034cb7 
Ref. #799

Signed-off-by: Jorge Orta <[email protected]>
@Orta21 Orta21 mentioned this pull request Jul 3, 2024
Merged
1 task
Orta21 added a commit that referenced this pull request Jul 9, 2024
@Orta21
fix(api): misc converter changes
b5eb810 
Ref. #799

Signed-off-by: Jorge Orta <[email protected]>
@Orta21 Orta21 mentioned this pull request Jul 9, 2024
Merged
3 tasks
Orta21 added a commit that referenced this pull request Jul 9, 2024
@Orta21
fix(api): no div if no value
55cc74e 
Ref. #799

Signed-off-by: Jorge Orta <[email protected]>
Orta21 added a commit that referenced this pull request Jul 9, 2024
@Orta21
fix(api): nit mr summary chages
e2f50ab 
Ref. #799

Signed-off-by: Jorge Orta <[email protected]>
Orta21 added a commit that referenced this pull request Jul 10, 2024
@Orta21
fix(api): dont throw error
3c38b68 
Ref. #799

Signed-off-by: Jorge Orta <[email protected]>
@Orta21 Orta21 mentioned this pull request Jul 10, 2024
Merged
1 task
jonahkaye added a commit that referenced this pull request Jul 10, 2024
@jonahkaye
fix(workflow): bug in deploy-production
275b18b 
Refs: #799
Signed-off-by: Jonah Kaye <[email protected]>
This was referenced Jul 10, 2024
Merged
Merged
Merged
@RamilGaripov RamilGaripov mentioned this pull request Jul 10, 2024
Merged
1 task
Orta21 added a commit that referenced this pull request Jul 11, 2024
@Orta21
fix(api): patch unknown display
114b463 
Ref. #799

Signed-off-by: Jorge Orta <[email protected]>
@Orta21 Orta21 mentioned this pull request Jul 11, 2024
Merged
3 tasks
Orta21 added a commit that referenced this pull request Jul 11, 2024
@Orta21
fix(api): patch unknown display merge conflict
bd60315 
Ref. #799

Signed-off-by: Jorge Orta <[email protected]>
@jonahkaye jonahkaye mentioned this pull request Jul 11, 2024
Merged
1 task
Orta21 added a commit that referenced this pull request Jul 11, 2024
@Orta21
fix(api): revert changes
958dc0e 
Ref. #799

Signed-off-by: Jorge Orta <[email protected]>
Orta21 added a commit that referenced this pull request Jul 11, 2024
@Orta21
fix(api): revert changes
3620a83 
Ref. #799

Signed-off-by: Jorge Orta <[email protected]>
@Orta21 Orta21 mentioned this pull request Jul 11, 2024
Merged
3 tasks
jonahkaye added a commit that referenced this pull request Jul 17, 2024
@jonahkaye
fix(stack): s3 from reference cert from reference
70cc685 
Refs: #799
Signed-off-by: Jonah Kaye <[email protected]>
This was referenced Jul 17, 2024
Merged
Merged
jonahkaye added a commit that referenced this pull request Jul 18, 2024
@jonahkaye
fix(cfn): rollback ihe stack changes
e5231c0 
Refs: #799
Signed-off-by: Jonah Kaye <[email protected]>
@jonahkaye jonahkaye mentioned this pull request Jul 18, 2024
Merged
4 tasks
Orta21 added a commit that referenced this pull request Jul 19, 2024
@Orta21
fix(api): remove unnecessary unknowns
534993c 
Ref. #799

Signed-off-by: Jorge Orta <[email protected]>
@Orta21 Orta21 mentioned this pull request Jul 19, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goncharo Goncharo Goncharo approved these changes

Assignees
No one assigned
Labels
released on @develop released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leite08 @Goncharo @RamilGaripov