Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add userId to Metadata #5

Closed
wants to merge 1 commit into from
Closed

Conversation

leite08
Copy link
Member

@leite08 leite08 commented Dec 23, 2022

Ticket: https://github.com/metriport/metriport-internal/issues/43

Add userId to Metadata, so the webhook payload can identify which user the data refers to.

This only changes the data package.

Release plan

  • Release this to NPN (minor version)
  • Merge master back into develop
  • Update the next feature branch of Update docs + mobile examples #43 to refer to the new data package version from NPM
    • Heads up: this will break existing mappings and require change on how we convert data into the shared data package

@Orta21
Copy link
Member

Orta21 commented Dec 23, 2022

When you say userid are you referring to the connected_user id right? Should we make this optional? Id not we need to make sure to update all of our mappings

@leite08
Copy link
Member Author

leite08 commented Dec 23, 2022

As discussed internally, we're taking a diff approach to specifying the Customer/Account's userId in the webhook payload, so I'm closing this PR and feature branch.

@leite08 leite08 closed this Dec 23, 2022
@leite08 leite08 deleted the 43-metadata-with-user-id branch December 26, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants