feat(retry): 3x initial delay on 429s #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: #1667 Signed-off-by: Jonah Kaye <[email protected]>
jonahkaye
commented
Jun 20, 2024
| headers: new AxiosHeaders(), | ||
| method: "post", | ||
| url: "", | ||
| }, |
There was a problem hiding this comment.
I needed to pass all this stuff in to conform to Axios typing
jonahkaye
commented
Jun 20, 2024
| expect(fn).toHaveBeenCalledTimes(2); | ||
| expect(spyDefaultGetTimeToWait).toHaveBeenCalledWith( | ||
| expect.objectContaining({ | ||
| initialDelay: 3, |
There was a problem hiding this comment.
ensuring delay was 3x as long
jonahkaye
requested review from
Goncharo,
leite08,
Orta21,
RamilGaripov and
thomasyopes
as code owners
thomasyopes
reviewed
Jun 20, 2024
thomasyopes
reviewed
Jun 20, 2024
thomasyopes
reviewed
Jun 20, 2024
Refs: #1667 Signed-off-by: Jonah Kaye <[email protected]>
Refs: #1667 Signed-off-by: Jonah Kaye <[email protected]>
leite08
approved these changes
Jun 20, 2024
Comment on lines
+37
to
+43
| function getHttpStatusFromError(error: unknown): number | undefined { | ||
| return axios.isAxiosError(error) ? error.response?.status : undefined; | ||
| } | ||
|
|
||
| function getHttpCodeFromError(error: unknown): string | undefined { | ||
| return axios.isAxiosError(error) ? error.code : undefined; | ||
| } |
Refs: #1667 Signed-off-by: Jonah Kaye <[email protected]>
Refs: #1667 Signed-off-by: Jonah Kaye <[email protected]>
Refs: #1667 Signed-off-by: Jonah Kaye <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #1667
Description
Testing
Release Plan