Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fhir-to-cda): inbound dq results in proper ccd #2311

Merged
merged 7 commits into from
Jun 21, 2024
Merged

feat(fhir-to-cda): inbound dq results in proper ccd #2311

merged 7 commits into from
Jun 21, 2024

Conversation

RamilGaripov
Copy link
Contributor

@RamilGaripov RamilGaripov commented Jun 20, 2024 •
edited
Loading

refs. #1892

Dependencies

Description

  • Decoupled FHIR-to-CDA conversion from file upload
  • Decoupled FHIR-to-CDA conversion from compositions splitter
  • Baked the CCD creation using the FHIR-to-CDA conversion upon incoming DQs
  • Improved the bundle hydration on data shareback

Testing

  • Local
    • Check with inbound DQs using the direct FHIR-to-CDA converter
    • Check data contributions still create CDAs using compositions
  • Staging
    • Check with inbound DQs using the lambda FHIR-to-CDA converter
    • Check data contributions still create CDAs using compositions

Release Plan

  • Merge this

@RamilGaripov RamilGaripov marked this pull request as ready for review June 20, 2024 22:57
@RamilGaripov
fix(fhir-to-cda): merged upstream
7ea0beb 
refs. #1892

Signed-off-by: Ramil Garipov <[email protected]>
leite08
leite08 approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@leite08 leite08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving w/ non-critical comments

packages/api/src/external/fhir-to-cda-converter/connector.ts Outdated Show resolved Hide resolved
packages/core/src/external/carequality/dq/process-inbound-dq.ts Outdated Show resolved Hide resolved
packages/core/src/external/carequality/dq/process-inbound-dq.ts Outdated Show resolved Hide resolved
Base automatically changed from 1892-shareback-improvements to develop June 21, 2024 17:14
@RamilGaripov RamilGaripov added this pull request to the merge queue Jun 21, 2024
Merged via the queue into develop with commit 7610b6c Jun 21, 2024
11 checks passed
@RamilGaripov RamilGaripov deleted the 1892-generate-ccd branch June 21, 2024 17:16
@RamilGaripov RamilGaripov mentioned this pull request Jun 21, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leite08 leite08 leite08 approved these changes

@Goncharo Goncharo Awaiting requested review from Goncharo Goncharo is a code owner

@Orta21 Orta21 Awaiting requested review from Orta21 Orta21 is a code owner

@jonahkaye jonahkaye Awaiting requested review from jonahkaye jonahkaye is a code owner

@thomasyopes thomasyopes Awaiting requested review from thomasyopes thomasyopes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RamilGaripov @leite08 @jonahkaye