1827 Apply executeWithRetries and the network one throughout #2285

leite08 · 2024-06-15T21:31:02Z

Ref. metriport/metriport-internal#1827

Dependencies

Upstream: 1827 Add backoff/jitter to executeWithRetries #2272
Downstream: none

Description

Follow-up to #2272, this attempts to add retries (mostly network ones) to calls to external services.

executeWithRetries: by default, retry on every error
executeWithNetworkRetries: by default, retry only on ECONNREFUSED and ECONNRESET

Refactor some logic especially around error handling.

Upgrade Axios to 1.4.0 to match API's.

Testing

Local
- PD works
- DQ works
- DR works
- Listing documents works
- ~~Converting document to PDF works~~ No local impl
Staging
- PD works
- DQ works
- DR works
- Listing documents works
- Converting document to PDF works
- Search documents
- Bulk download doc URLs
Sandbox
- none
Production
- none

Release Plan

Publish NPM packages
Merge this

leite08 · 2024-06-15T21:33:32Z

packages/api/src/external/commonwell/patient-external-data.ts

+ const patient = patientDB.dataValues;
+ return {
+ ...patient,
+ data: {
+ ...patient.data,
+ externalData: {
+ ...patient.data.externalData,
+ COMMONWELL: cwData,
+ },
+ },
+ };


Avoid casting

packages/api/src/external/commonwell/patient-external-data.ts

packages/core/src/external/aws/document-signing/bulk-sign.ts

packages/core/src/external/carequality/pd/process-inbound-pd.ts

packages/lambdas/src/cw-doc-contribution.ts

packages/lambdas/src/document-downloader.ts

packages/lambdas/src/sqs-to-converter.ts

jonahkaye

My main concern here is with using executeWithRetries not at the lowest possible level. My heuristic would be to always put it actually in the file that uses axios or the s3 sdk or the cw sdk as opposed to a more upstream function. I think of the retries as a low level protocol that should be done as close to the call to the external service as possible.

thoughts?

packages/shared/src/net/error.ts

packages/core/src/external/carequality/ihe-gateway-v2/ihe-gateway-v2-logic.ts

Ref. metriport/metriport-internal#1827 Signed-off-by: Rafael Leite <[email protected]>

- apply executeWithRetries to lower level funcitons - remove the deprecated S3Utils from lambdas package Ref. metriport/metriport-internal#1827 Signed-off-by: Rafael Leite <[email protected]>

Ref. metriport/metriport-internal#1827 Signed-off-by: Rafael Leite <[email protected]>

Ref: #000 - [email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - [email protected] - @metriport/[email protected] - @metriport/[email protected] - [email protected] Signed-off-by: Rafael Leite <[email protected]>

leite08 force-pushed the 1827-update-lambdas-to-retry branch from 6dc7f4e to 503f583 Compare June 15, 2024 21:32

leite08 commented Jun 15, 2024

View reviewed changes

leite08 marked this pull request as ready for review June 15, 2024 21:42

leite08 requested review from Goncharo, Orta21, RamilGaripov, jonahkaye and thomasyopes as code owners June 15, 2024 21:42