1801 Remove code dups for search and get documents #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leite08
commented
Jun 15, 2024
| documentIds?: string[]; | ||
| from?: string | undefined; | ||
| to?: string | undefined; | ||
| } = {}) { | ||
| const filters = new URLSearchParams(); | ||
| patientId && filters.append("patient", patientId); | ||
| documentIds.length && filters.append(`_ids`, documentIds.join(",")); |
leite08
requested review from
Goncharo,
Orta21,
RamilGaripov,
jonahkaye and
thomasyopes
as code owners
Ref. metriport/metriport-internal#1801 Signed-off-by: Rafael Leite <[email protected]>
Ref. metriport/metriport-internal#1801 Signed-off-by: Rafael Leite <[email protected]>
- return docRef w/ ID on search to avoid casting Ref. metriport/metriport-internal#1801 Signed-off-by: Rafael Leite <[email protected]>
Ref. metriport/metriport-internal#1801 Signed-off-by: Rafael Leite <[email protected]>
Orta21
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://github.com/metriport/metriport-internal/issues/1801
Dependencies
Description
Remove code dups for search and get documents.
Testing
Release Plan