Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1868 map family history #2266

Merged
merged 12 commits into from
Jun 27, 2024
Merged

1868 map family history #2266

merged 12 commits into from
Jun 27, 2024

Conversation

RamilGaripov
Copy link
Contributor

@RamilGaripov RamilGaripov commented Jun 13, 2024 •
edited
Loading

Ticket: https://github.com/metriport/metriport-internal/issues/1868

Dependencies

Description

  • Added FamilyHistory mapping
  • Added unit tests
  • Other small changes

Testing

  • Local
    • Tried locally with a valid FHIR bundle to get a valid CDA document
  • Staging
    • Add FamilyMemberHistory and see that it gets input into CCD

Release Plan

  • Merge this

@RamilGaripov
feat(fhir-to-cda): wip - family history mapping
e1c89d7 
refs. #1868

Signed-off-by: Ramil Garipov <[email protected]>
@RamilGaripov
fix(fhir-to-cda): merged upstream
4200377 
refs. #1868

Signed-off-by: Ramil Garipov <[email protected]>
@RamilGaripov
feat(fhir-to-cda): added types to family history mapping
707317a 
refs. #1868

Signed-off-by: Ramil Garipov <[email protected]>
@RamilGaripov
fix(fhir-to-cda): minor fix
3ae8227 
refs. #1868

Signed-off-by: Ramil Garipov <[email protected]>
@RamilGaripov
feat(fhir-to-cda): added unit tests + mapping improvements
dde5f40 
refs. #1868

Signed-off-by: Ramil Garipov <[email protected]>
@RamilGaripov
fix(fhir-to-cda): merged upstream
71accf8 
refs. #1868

Signed-off-by: Ramil Garipov <[email protected]>
@RamilGaripov
fix(fhir-to-cda): atomic ids for condition refs
afd1fc4 
refs. #1868

Signed-off-by: Ramil Garipov <[email protected]>
@RamilGaripov
fix(fhir-to-cda): a couple other small improvements
3eb5df1 
refs. #1868

Signed-off-by: Ramil Garipov <[email protected]>
@RamilGaripov
fix(fhir-to-cda): merged upstream
5b506f6 
refs. metriport/metriport-internal#1868

Signed-off-by: Ramil Garipov <[email protected]>
@RamilGaripov RamilGaripov marked this pull request as ready for review June 24, 2024 19:15
@RamilGaripov RamilGaripov mentioned this pull request Jun 26, 2024
Open
2 tasks
jonahkaye
jonahkaye reviewed Jun 27, 2024
View reviewed changes
Copy link
Member

@jonahkaye jonahkaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Main comment is about having a structured value field in the observation within the family member history so there is structured data to parse.

Also, just wanted to check on the status of Epic testing on staging. Can we bump that if its been stalled? If this is the last section, we could also just wait to bump that until we ship this but there will definetly be issues on their end so ....

@RamilGaripov
Copy link
Contributor Author

Also, just wanted to check on the status of Epic testing on staging. Can we bump that if its been stalled? If this is the last section, we could also just wait to bump that until we ship this but there will definetly be issues on their end so ....

I will construct an updated version of the CDA and ping them again..

jonahkaye
jonahkaye reviewed Jun 27, 2024
View reviewed changes
packages/core/src/domain/patient-demographics.ts
return "F";
default:
return "UK";
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

second thought. This is supposed to be converting fhir to CDA, but f and m are not valid values in fhir.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and also the name of the function should convey that its converting from fhir to CDA

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol true.. But I'll keep a copy of this function here for future use :P

jonahkaye
jonahkaye approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@jonahkaye jonahkaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved conditional on resolving last comment

@RamilGaripov RamilGaripov added this pull request to the merge queue Jun 27, 2024
@RamilGaripov RamilGaripov mentioned this pull request Jun 27, 2024
Merged
1 task
Merged via the queue into develop with commit 2e49dd8 Jun 27, 2024
11 checks passed
@RamilGaripov RamilGaripov deleted the 1868-map-family-history branch June 27, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahkaye jonahkaye jonahkaye approved these changes

@Goncharo Goncharo Awaiting requested review from Goncharo Goncharo is a code owner

@leite08 leite08 Awaiting requested review from leite08 leite08 is a code owner

@Orta21 Orta21 Awaiting requested review from Orta21 Orta21 is a code owner

@thomasyopes thomasyopes Awaiting requested review from thomasyopes thomasyopes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RamilGaripov @jonahkaye